Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#9253 - logf file output patch.

Attached to Project: Rockbox
Opened by Yoshihisa Uchida (Uchida) - Friday, 08 August 2008, 15:28 GMT+2
Task Type Patches
Category Applications
Status Unconfirmed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 0%
Private No

Details

It is a patch that can automatically output the result of logf to the
file.


The setting of default doesn't output the result of the logf to the
file.
Please set and do the following when it is effective.

System > Debug > logf auto file output: select "Yes"
   logf_output.patch (35.7 KiB) 
 apps/lang/english.lang      |   14 
 apps/settings.h             |    5 
 apps/settings_list.c        |    4 
 apps/debug_menu.c           |   32 +
 apps/main.c                 |   17 
 apps/misc.c                 |   10 
 firmware/export/logf.h      |    8 
 firmware/export/asyncfile.h |   55 ++
 firmware/logf.c             |   69 ++-
 firmware/SOURCES            |    1 
 firmware/asyncfile.c        | 1011 ++++++++++++++++++++++++++++++++++++++++++++
 11 files changed, 1223 insertions(+), 3 deletions(-)

This task depends upon

Comment by Nicolas Pennequin (nicolas_p) - Friday, 08 August 2008, 16:36 GMT+2
Are you sure a whole new set of file functions is needed? Also, did ou write all of asyncfile.c?
Comment by Yoshihisa Uchida (Uchida) - Sunday, 10 August 2008, 16:46 GMT+2
If asyncfile.c was not used when the log is output to the file,
then it not be output to the file or only a part of the log be output
when the load of Rockbox is high (playing music or movie).

The patch file to output the log to the file without using asyncfile.c was prepared,
and confirm the output of the log is different, please.
Comment by Yoshihisa Uchida (Uchida) - Sunday, 10 August 2008, 16:59 GMT+2
Sorry, I don't send patch file.

fs_logf_no_asyncfile.patch
　It is a patch file to output the log to the file without using asyncfile.c.

rev_logf.txt
It is a file that upsets the top and bottom of the line to the execution result of logfdump(logf.txt).

logf.log
　It is a log file that Rockbox that applied fs_logf_no_asyncfile.patch.

When it compare rev_logf.txt with logf.log,
The 635-660th line and the 681-683th line of rev_logf.txt is
different from logf.log.

   fs_logf_no_asyncfile.patch (5.3 KiB) 
 apps/settings.h        |    1 
 apps/main.c            |    7 ++++
 apps/misc.c            |    8 +++++
 firmware/export/logf.h |   13 +++++++--
 firmware/logf.c        |   69 ++++++++++++++++++++++++++++++++++++++++++++++---
 5 files changed, 93 insertions(+), 5 deletions(-)

   rev_logf.txt (27.2 KiB)
   logf.log (21.9 KiB)
Comment by Jens Erdmann (pyro_maniac) - Tuesday, 10 March 2009, 17:49 GMT+2
I attached a file with a actual and minimal version but i didn't had the chance to test it enoght.
   file_log.patch (3.4 KiB) 
 apps/main.c            |    9 +++++++++
 apps/misc.c            |    9 +++++++++
 apps/settings.h        |    1 +
 firmware/export/logf.h |    4 ++++
 firmware/logf.c        |   43 +++++++++++++++++++++++++++++++++++++++++++
 5 files changed, 66 insertions(+)

Comment by Yoshihisa Uchida (Uchida) - Wednesday, 11 March 2009, 15:22 GMT+2
Processing slows very much when the log is effective because logf() doesn't end if writing in the file is not completed.
For example, when the log is output when a music has been played, the slowness of processing can be experienced.
Because processing is not slowed down when the log is output, the asyncfile.c is needed.

My patch file cannot be applyed in the Rockbox of the latest version.
Ｉｆ the new patch file is necessary, please wait for the patch file that can be appropriated to the latest version.
Comment by Jens Erdmann (pyro_maniac) - Wednesday, 11 March 2009, 15:56 GMT+2
so i will wait for a new patch to come along with my port. Thanks for doing this.
Comment by Yoshihisa Uchida (Uchida) - Thursday, 12 March 2009, 13:42 GMT+2
I corrected my patch file to apply it to the Rockbox of the latest version.
Please report on the operation when this patch is used.
   logf_output_2.patch (7.3 KiB) 
 b/apps/debug_menu.c      |   32 +++++++++++++++++++++++++
 b/apps/lang/english.lang |   14 ++++++++++
 b/apps/main.c            |   17 +++++++++++++
 b/apps/misc.c            |   10 +++++++
 b/apps/settings.h        |    5 +++
 b/apps/settings_list.c   |    4 +++
 b/firmware/SOURCES       |    1 
 b/firmware/export/logf.h |    7 +++++
 b/firmware/logf.c        |   60 +++++++++++++++++++++++++++++++++++++++++++++++
 9 files changed, 150 insertions(+)

Comment by Jens Erdmann (pyro_maniac) - Thursday, 12 March 2009, 20:56 GMT+2
There are still several bugs in. asyncfile.c is inserted in SOURCES but there is no file. The boolean in settings.h is in the enum.
Comment by Yoshihisa Uchida (Uchida) - Saturday, 21 March 2009, 15:27 GMT+2
Sorry, my patch file build failure.
It updates. I think that the Rockbox firmware build success.
   logf_output_3.patch (34.2 KiB) 
 b/apps/debug_menu.c           |   32 +
 b/apps/lang/english.lang      |   14 
 b/apps/main.c                 |   17 
 b/apps/misc.c                 |   10 
 b/apps/settings.h             |    6 
 b/apps/settings_list.c        |    4 
 b/firmware/SOURCES            |    1 
 b/firmware/export/logf.h      |    7 
 b/firmware/logf.c             |   60 ++
 b/firmware/asyncfile.c        | 1011 ++++++++++++++++++++++++++++++++++++++++++
 b/firmware/export/asyncfile.h |   55 ++
 11 files changed, 1217 insertions(+)

Comment by Jens Erdmann (pyro_maniac) - Saturday, 21 March 2009, 19:46 GMT+2
There are still some warnings on applying but it works for me. Thanks for help!
Comment by Yoshihisa Uchida (Uchida) - Thursday, 26 March 2009, 12:00 GMT+2
sync r20543.
I confirmed the build was able to be done to iPod video, iriver H120 and Sansa e200.
   logf_output_4.patch (34.3 KiB) 
 b/apps/debug_menu.c           |   32 +
 b/apps/lang/english.lang      |   16 
 b/apps/main.c                 |   17 
 b/apps/misc.c                 |   10 
 b/apps/settings.h             |    6 
 b/apps/settings_list.c        |    4 
 b/firmware/SOURCES            |    1 
 b/firmware/export/logf.h      |    7 
 b/firmware/logf.c             |   60 ++
 b/firmware/asyncfile.c        | 1011 ++++++++++++++++++++++++++++++++++++++++++
 b/firmware/export/asyncfile.h |   55 ++
 11 files changed, 1218 insertions(+), 1 deletion(-)

Comment by Jens Erdmann (pyro_maniac) - Thursday, 26 March 2009, 13:20 GMT+2
Patch 3 works on a h10 5g build too.

Loading...