Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#9280 - fix "make tar" for BSD tar compatibility

Attached to Project: Rockbox
Opened by Geert Hendrickx (ghen) - Thursday, 14 August 2008, 15:27 GMT+2
Last edited by Jens Arnold (amiconn) - Wednesday, 27 August 2008, 01:23 GMT+2
Task Type Patches
Category Build environment
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

The "make tar" target uses tar -u to update an existing tarfile. This doesn't work however with BSD tar if the tarfile doesn't exist yet, and the Makefile explicitly removes the tarfile initially (so why use -u anyway?). Changing -u (update) into -c (create) makes this compatible with both GNU and BSD tar (tested on NetBSD with both versions of tar).
   maketar.diff (0.6 KiB) 
 tools/configure |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

This task depends upon

Closed by  Jens Arnold (amiconn)
Wednesday, 27 August 2008, 01:23 GMT+2
Reason for closing:  Fixed
Additional comments about closing:  Fix committed to SVN, including the necessary buildzip.pl changes.
Comment by Geert Hendrickx (ghen) - Wednesday, 27 August 2008, 00:10 GMT+2
"tar -c" is not the proper solution since $ziptool may be called twice (when including fonts).

As agreed on IRC, it would be better to modify buildzip.pl to call $ziptool only once.

Loading...