Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#9333 - pictureflow: buffer overflow when track number is over 50

Attached to Project: Rockbox
Opened by Tomasz Wasilczyk (tomkiewicz) - Thursday, 28 August 2008, 16:46 GMT+2
Last edited by Andrew Mahone (Unhelpful) - Saturday, 16 May 2009, 04:46 GMT+2
Task Type Bugs
Category Plugins
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

When ID3 tag track number is greater than 50 (ie. some bonus tracks are ripped with "99" track number), there is buffer overflow. When user enters the album with such track, there are about 32 more "tracks", but with crappy titles.

I've made patch that solves this bug and tested it with and without http://www.rockbox.org/tracker/task/9331 - both works OK
   pf_buffer_overflow.diff (2.2 KiB) 
 apps/plugins/pictureflow.c |   26 ++++++++++++++++++--------
 1 file changed, 18 insertions(+), 8 deletions(-)

This task depends upon

Closed by  Andrew Mahone (Unhelpful)
Saturday, 16 May 2009, 04:46 GMT+2
Reason for closing:  Fixed
Additional comments about closing:  Fixed as of r20938.
Comment by Tomasz Wasilczyk (tomkiewicz) - Thursday, 28 August 2008, 17:07 GMT+2
uhh, I've removed one empty line by accident - here is fixed patch
   pf_buffer_overflow_v2.patch (2.1 KiB) 
 apps/plugins/pictureflow.c |   25 ++++++++++++++++++-------
 1 file changed, 18 insertions(+), 7 deletions(-)

Loading...