Rockbox

Tasklist

FS#9344 - Mutlitarget WPS Editor

Attached to Project: Rockbox
Opened by krz (krz) - Sunday, 31 August 2008, 10:06 GMT
Last edited by Dominik Wenger (Domonoky) - Wednesday, 03 September 2008, 19:25 GMT
Task Type Patches
Category Applications
Status Closed
Assigned To No-one
Operating System All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

This patch enables ability to switch different targets on runtime. Currently not all targets available.
This task depends upon

Closed by  Dominik Wenger (Domonoky)
Wednesday, 03 September 2008, 19:25 GMT
Reason for closing:  Accepted
Comment by krz (krz) - Sunday, 31 August 2008, 16:24 GMT
Added comment highliting, added error handling, added debug output. From now default build will be "debug". README tels how to build release.
Comment by Dominik Riebeling (bluebrother) - Sunday, 31 August 2008, 16:31 GMT
it looks like the diff contains some files (almost) completely unchanged -- looks pretty much like a line ending issue to me. Please make sure to ignore line endings when creating diffs (diff -b) so they only contain the real changes.
Comment by Dominik Wenger (Domonoky) - Sunday, 31 August 2008, 18:02 GMT
Apart from what bluebrother said, the patch looks nice.

One of the missing things is, the automatic build of the libs.
You could change the build command for libwps in the gui.pro to call the buildall shell script... :-)

Also it seems its only possible to build libwps libs for colour targets. But that can be fixed later.
Comment by Dominik Riebeling (bluebrother) - Sunday, 31 August 2008, 18:55 GMT
using a shell script for building the various libwps versions doesn't sound like a good idea to me -- you get a dependency to a sh-compatible shell, and on w32 you most probably won't have one installed. IMO it would be much better using a list with targets to build and trying to use wildcard matching.
Comment by krz (krz) - Tuesday, 02 September 2008, 13:44 GMT
New build system. Bat-files for win, sh-files for lunix.
Comment by Maurus Cuelenaere (mcuelenaere) - Tuesday, 02 September 2008, 21:06 GMT
You forgot to include qsyntaxer.cpp in your diff...

Next to that I still get these error messages:
9 libs found
"ERR: failed to resolve <get_model_name>"
"libwps_c200.so" "unknown"
"ERR: failed to resolve <get_model_name>"
"libwps_e200.so" "unknown"
"ERR: failed to resolve <get_model_name>"
"libwps_gigabeatf.so" "unknown"
"ERR: failed to resolve <get_model_name>"
"libwps_gigabeats.so" "unknown"
"ERR: failed to resolve <get_model_name>"
"libwps_h10.so" "unknown"
"libwps_h10_5gb.so" "h10_5gb"
"ERR: failed to resolve <get_model_name>"
"libwps_ipodcolor.so" "unknown"
"ERR: failed to resolve <get_model_name>"
"libwps_ipodnano.so" "unknown"
"ERR: failed to resolve <get_model_name>"
"libwps_ipodvideo.so" "unknown"

EDIT:
A fix for this is (I'm too lazy to make a one-line patch):
change l.225 in qwpsdrawer.cpp to this:

QString modelName = getModelName(qApp->applicationDirPath()+"/"+libs[i].fileName());


EDIT2:
Building on MingW on Windows seems to be broken for me (using buildall.bat), I can only build by doing 'qmake && make release' in gui & gui/src/QPropertyEditor manually..
Comment by Maurus Cuelenaere (mcuelenaere) - Tuesday, 02 September 2008, 21:50 GMT
I took the liberty of adding some extra syntax rules with coloring/formatting.
What do you think?
Comment by krz (krz) - Wednesday, 03 September 2008, 17:32 GMT
Now qsyntaxer.cpp is included :)

Error "ERR: failed to resolve <get_model_name>" is solved.

To build on mingw you should add your Qt/bin and mingw/bin dirs to PATH and run script from Qt command line.

Your syntax highliting added.

Loading...