Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#9350 - Fix WPS crash on some simple tags

Attached to Project: Rockbox
Opened by Alexander Levin (fml2) - Monday, 01 September 2008, 20:21 GMT+2
Last edited by Nicolas Pennequin (nicolas_p) - Saturday, 06 September 2008, 19:44 GMT+2
Task Type Patches
Category Applications
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

There is a bug in the WPS interpreter. How to reproduce:

Create a simple WPS containing just one of the following tags (standalone, not as a conditional switch): %mm, %mp

As soon as WPS screen is shown, I get segmentation fault. I didn't try it on the target, only on the sim.

Attached is the correcting patch.
   wps_simple_tags.patch (2.2 KiB) 
 apps/gui/gwps-common.c |   41 +++++++++++++++++++++++++++++------------
 1 file changed, 29 insertions(+), 12 deletions(-)

This task depends upon

Closed by  Nicolas Pennequin (nicolas_p)
Saturday, 06 September 2008, 19:44 GMT+2
Reason for closing:  Accepted
Additional comments about closing:  r18420 + r18421
Comment by Maurus Cuelenaere (mcuelenaere) - Wednesday, 03 September 2008, 00:20 GMT+2
This also affects WPS editor.
Comment by Nicolas Pennequin (nicolas_p) - Saturday, 06 September 2008, 19:43 GMT+2
I committed the bugfix but decided to leave the function out... IMHO it didn't help code readability.

Loading...