Rockbox

Tasklist

FS#9350 - Fix WPS crash on some simple tags

Attached to Project: Rockbox
Opened by Alexander Levin (fml2) - Monday, 01 September 2008, 18:21 GMT
Last edited by Nicolas Pennequin (nicolas_p) - Saturday, 06 September 2008, 17:44 GMT
Task Type Patches
Category Applications
Status Closed
Assigned To No-one
Operating System All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

There is a bug in the WPS interpreter. How to reproduce:

Create a simple WPS containing just one of the following tags (standalone, not as a conditional switch): %mm, %mp

As soon as WPS screen is shown, I get segmentation fault. I didn't try it on the target, only on the sim.

Attached is the correcting patch.
This task depends upon

Closed by  Nicolas Pennequin (nicolas_p)
Saturday, 06 September 2008, 17:44 GMT
Reason for closing:  Accepted
Additional comments about closing:  r18420 + r18421
Comment by Maurus Cuelenaere (mcuelenaere) - Tuesday, 02 September 2008, 22:20 GMT
This also affects WPS editor.
Comment by Nicolas Pennequin (nicolas_p) - Saturday, 06 September 2008, 17:43 GMT
I committed the bugfix but decided to leave the function out... IMHO it didn't help code readability.

Loading...