Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#9361 - Colour selection screen broken with large font (all colour targets)

Attached to Project: Rockbox
Opened by Jens Arnold (amiconn) - Wednesday, 03 September 2008, 22:47 GMT+1
Last edited by Peter D'Hoye (petur) - Sunday, 07 September 2008, 22:09 GMT+1
Task Type Bugs
Category User Interface
Status Closed
Assigned To No-one
Player Type Iriver H300 series
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

The colour selection screen is broken with larger fonts (>= 14 pixels is sufficient for reproducing the bug). The R/G/B to the left of the sliders and the values to the right overlap each other, because the vertical slider spacing isn't adjusted to the font size.

Also, the RGB value shown in the colour example rectangle should probably be printed using the user font, not the sysfont.
This task depends upon

Closed by  Peter D'Hoye (petur)
Sunday, 07 September 2008, 22:09 GMT+1
Reason for closing:  Fixed
Comment by Peter D'Hoye (petur) - Sunday, 07 September 2008, 14:22 GMT+1
attached patch fixes this.... comments on the solution?
   charheight.patch (17.5 KiB) 
 utils/wpseditor/libwps/src/lcd.c |    5 ++
 apps/screen_access.c             |   81 ++++++++++++++++++++++++++-------------
 apps/screen_access.h             |    7 +--
 apps/onplay.c                    |    5 +-
 apps/gui/charcell/list.c         |    8 +--
 apps/gui/pitchscreen.c           |    6 +-
 apps/gui/color_picker.c          |   53 +++++++++++++------------
 apps/gui/quickscreen.c           |    2 
 apps/playlist_viewer.c           |    6 +-
 firmware/export/lcd.h            |    1 
 firmware/export/lcd-remote.h     |    1 
 firmware/drivers/lcd-charcell.c  |   14 +++++-
 firmware/drivers/lcd-1bit-vert.c |    5 ++
 firmware/drivers/lcd-2bit-vert.c |    5 ++
 firmware/drivers/lcd-2bit-vi.c   |    5 ++
 firmware/drivers/lcd-16bit.c     |    5 ++
 16 files changed, 140 insertions(+), 69 deletions(-)

Comment by Peter D'Hoye (petur) - Sunday, 07 September 2008, 16:11 GMT+1
better?
   charheight2.patch (12.9 KiB) 
 apps/screen_access.c     |   79 ++++++++++++++++++++++++++++++++---------------
 apps/screen_access.h     |    6 +--
 apps/onplay.c            |    5 +-
 apps/gui/charcell/list.c |    8 ++--
 apps/gui/pitchscreen.c   |    6 +--
 apps/gui/color_picker.c  |   53 ++++++++++++++++---------------
 apps/gui/quickscreen.c   |    2 -
 apps/playlist_viewer.c   |    6 +--
 8 files changed, 99 insertions(+), 66 deletions(-)

Comment by Peter D'Hoye (petur) - Sunday, 07 September 2008, 16:18 GMT+1
fix a warning
   charheight3.patch (12.9 KiB) 
 apps/screen_access.c     |   79 ++++++++++++++++++++++++++++++++---------------
 apps/screen_access.h     |    6 +--
 apps/onplay.c            |    5 +-
 apps/gui/charcell/list.c |    8 ++--
 apps/gui/pitchscreen.c   |    6 +--
 apps/gui/color_picker.c  |   53 ++++++++++++++++---------------
 apps/gui/quickscreen.c   |    2 -
 apps/playlist_viewer.c   |    6 +--
 8 files changed, 99 insertions(+), 66 deletions(-)

Comment by Peter D'Hoye (petur) - Sunday, 07 September 2008, 16:22 GMT+1
fix error for certain archos players
   charheight4.patch (12.9 KiB) 
 apps/screen_access.c     |   79 ++++++++++++++++++++++++++++++++---------------
 apps/screen_access.h     |    6 +--
 apps/onplay.c            |    5 +-
 apps/gui/charcell/list.c |    8 ++--
 apps/gui/pitchscreen.c   |    6 +--
 apps/gui/color_picker.c  |   53 ++++++++++++++++---------------
 apps/gui/quickscreen.c   |    2 -
 apps/playlist_viewer.c   |    6 +--
 8 files changed, 99 insertions(+), 66 deletions(-)

Comment by Peter D'Hoye (petur) - Sunday, 07 September 2008, 16:42 GMT+1
includes remote functions - no longer crashes targets with remotes ;)
   charheight5.patch (13.4 KiB) 
 apps/screen_access.c     |   99 +++++++++++++++++++++++++++++++++++------------
 apps/screen_access.h     |    6 +-
 apps/onplay.c            |    5 +-
 apps/gui/charcell/list.c |    8 +--
 apps/gui/pitchscreen.c   |    6 +-
 apps/gui/color_picker.c  |   53 +++++++++++++------------
 apps/gui/quickscreen.c   |    2 
 apps/playlist_viewer.c   |    6 +-
 8 files changed, 119 insertions(+), 66 deletions(-)

Loading...