Rockbox

Tasklist

FS#9363 - WPS editor build cleanup

Attached to Project: Rockbox
Opened by Maurus Cuelenaere (mcuelenaere) - Thursday, 04 September 2008, 00:22 GMT
Last edited by Maurus Cuelenaere (mcuelenaere) - Thursday, 04 September 2008, 14:50 GMT
Task Type Patches
Category Themes
Status Closed
Assigned To No-one
Operating System All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

This patch changes the build behaviour as discussed in #rockbox-community.

It's only for WPS editor, checkwps is unchanged.
This task depends upon

Closed by  Maurus Cuelenaere (mcuelenaere)
Thursday, 04 September 2008, 14:50 GMT
Reason for closing:  Accepted
Additional comments about closing:  In r18407.
Comment by Frank Gevaerts (fg) - Thursday, 04 September 2008, 12:35 GMT
With careful/conditional setting of LDFLAGS it should be possible to unify the libwps_%.dll and libwps_%.so targets I think. (It would then be libwps_%$(EXE) of course) That would further simplify the makefile
Comment by Maurus Cuelenaere (mcuelenaere) - Thursday, 04 September 2008, 13:26 GMT
This simplifies the Makefile.

Libwps still isn't build when doing 'qmake-qt4 && make' in the root dir though..
Comment by Frank Gevaerts (fg) - Thursday, 04 September 2008, 13:39 GMT
$(RM) $(RESULTS) instead of $(RM) libwps_* ?

edit: same for $(COPY) I guess
Comment by Frank Gevaerts (fg) - Thursday, 04 September 2008, 14:28 GMT
Adding libwps to the SUBDIRS line in wpseditor.pro seems to get qmake to do the right thing
Comment by Maurus Cuelenaere (mcuelenaere) - Thursday, 04 September 2008, 14:43 GMT
Contains the fixes gevaerts suggested.

Loading...