Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#9383 - chessclock freezes on deleting a player

Attached to Project: Rockbox
Opened by Frank Gevaerts (fg) - Monday, 08 September 2008, 23:10 GMT+2
Last edited by Teruaki Kawashima (teru) - Thursday, 09 July 2009, 15:42 GMT+2
Task Type Bugs
Category Applications
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

To reproduce :
start chessclock
choose two players
choose any time value you like
once everything is setup, get the menu
select Delete player
press any button
The player is now frozen

Reproduced on ipod video, ipod mini, H120, gigabeat F, X5, and Archos player
This task depends upon

Closed by  Teruaki Kawashima (teru)
Thursday, 09 July 2009, 15:42 GMT+2
Reason for closing:  Accepted
Additional comments about closing:  committed as r21733. thanks.
Comment by Yoshihisa Uchida (Uchida) - Thursday, 08 January 2009, 03:04 GMT+2
I confirmed this bug.

I send the patch file.
Please confirm it.
   chessclock.patch (1.3 KiB) 
 b/apps/plugins/chessclock.c |   21 +++++++++++++--------
 1 file changed, 13 insertions(+), 8 deletions(-)

Comment by Yoshihisa Uchida (Uchida) - Tuesday, 17 March 2009, 10:07 GMT+2
sync r20338
   chessclock_2.patch (1.3 KiB) 
 b/apps/plugins/chessclock.c |   21 +++++++++++++--------
 1 file changed, 13 insertions(+), 8 deletions(-)

Comment by Teruaki Kawashima (teru) - Wednesday, 03 June 2009, 15:16 GMT+2
I noticed one issue in Uchida's patch.
if a player is deleted, switching to previous player is not work properly.
e.g.
1. start with 3 players.
2. delete one of them. e.g. 2nd player.
3. now, 3rd player is displayed.
4. press button to show previous player. player is not changed.
i think 1st player should be displayed.
here is a patch that enables to show previous player.
Could someone confirm this?
   chessclock.patch (2 KiB) 
 apps/plugins/chessclock.c |   40 ++++++++++++++++++++--------------------
 1 file changed, 20 insertions(+), 20 deletions(-)

Comment by Yoshihisa Uchida (Uchida) - Friday, 05 June 2009, 12:54 GMT+2
Hi, Kawashima, thank you for the report about another problem.
I confirmed this problem.
Because your patch file is baesed on  FS#9707 , I corrected it to this task's patch (chessclock_2.patch).
I corrected the patch of  FS#9707  too. Please look at  FS#9707 .





   chessclock_3.patch (1.8 KiB) 
 b/apps/plugins/chessclock.c |   29 ++++++++++++++++++-----------
 1 file changed, 18 insertions(+), 11 deletions(-)

Comment by Yoshihisa Uchida (Uchida) - Wednesday, 17 June 2009, 11:20 GMT+2
sync r21316
   chessclock_4.patch (1.8 KiB) 
 b/apps/plugins/chessclock.c |   29 ++++++++++++++++++-----------
 1 file changed, 18 insertions(+), 11 deletions(-)

Loading...