Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#9388 - keyclicks too late

Attached to Project: Rockbox
Opened by Johannes Linke (Jaykay) - Tuesday, 09 September 2008, 11:25 GMT+2
Last edited by Michael Sevakis (MikeS) - Saturday, 13 December 2008, 02:36 GMT+2
Task Type Bugs
Category Settings
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

the keyklicks comes about half a second too late. i dont know what i should add^^
This task depends upon

Closed by  Michael Sevakis (MikeS)
Saturday, 13 December 2008, 02:36 GMT+2
Reason for closing:  Fixed
Additional comments about closing:  Should be fixed in r19411. Click is mixed-in just behind current DMA position.
Comment by Frank Gevaerts (fg) - Tuesday, 09 September 2008, 12:07 GMT+2
You could add for instance what player you're using...
Comment by Jonathan Gordon (jdgordon) - Tuesday, 09 September 2008, 12:10 GMT+2
well... thats irrelevant really seen as no targets are using the hardware clicker.... and this is another "not a bug" imo... its clicking at the earliest possible moment (that it makes sense to click)...
Comment by Johannes Linke (Jaykay) - Tuesday, 09 September 2008, 13:04 GMT+2
sansa e280...

the earliest possible moment? how much has the player to do between pressing a button and playing a "click"? it seems its a lot... and when "no targets use the hardware clicker" than you can remove it.
Comment by Dominik Riebeling (bluebrother) - Wednesday, 10 September 2008, 00:43 GMT+2
PLEASE read the Flyspray guide before filing tasks. Writing "i dont know what i should add" clearly shows that you don't know what information are useful. Revision number of the used build and player would be the ones most obvious.
Comment by Johannes Linke (Jaykay) - Wednesday, 10 September 2008, 14:53 GMT+2
what behaviour i see: as i wrote the keyclicks are too late.
what behaviour i expect: the keyclicks should come when a button is pressed. as i wrote.
how to reproduce the bug: enable keyclicks and press a button. i think this was clear.
svn: r18464 from the rockbox-site. sansa e280. im sorry for leaving out this, i thought the player would be equal (?).
Comment by Dominik Riebeling (bluebrother) - Friday, 12 September 2008, 23:49 GMT+2
please define "too late". A term like "too late" is highly subjective, and what you'd consider too late might be nothing I'd consider too late. Also, please post the relevant sections of your configuration -- especially, do you have keyclick repeat enabled?

Players are greatly different. Keyclick works 100% reliably on h100. As this player even has a different CPU this is absolutely not comparable (there has to be a reason why we have a "player type" filed, does it?)
Comment by Johannes Linke (Jaykay) - Monday, 15 September 2008, 18:23 GMT+2
you have to read what i wrote... i wrote "about half a second", and think half a second is not highly subjective.

i have used the r18464 for testing this bug, and i didnt change much in the settings. keyclick repeat is disabled, becouse it doesnt work too... when i scroll with the wheel the player doesnt stop clicking, althoug i stopped scrolling.

and as i wrote in one comment i use the sansa e280.
Comment by Michael Sevakis (MikeS) - Friday, 12 December 2008, 23:18 GMT+2
This should hasten the keyclick during playback.
   click-NOW.diff (1.3 KiB) 
 apps/pcmbuf.c |   20 ++++++++++++++++----
 1 file changed, 16 insertions(+), 4 deletions(-)

Comment by Michael Sevakis (MikeS) - Friday, 12 December 2008, 23:32 GMT+2
Oops. I should really check wrapping after incrementing to allow some space.
   click-NOWv1.1.diff (1.4 KiB) 
 apps/pcmbuf.c |   25 +++++++++++++++++++++----
 1 file changed, 21 insertions(+), 4 deletions(-)

Loading...