This is the bug/patch tracker for Rockbox. Click here for more information.
Quick links: Bugs · Patches · Rockbox frontpage
FS#9407 - bookmarks overhaul
Attached to Project:
Rockbox
Opened by Jonathan Gordon (jdgordon) - Tuesday, 16 September 2008, 10:32 GMT+2
Opened by Jonathan Gordon (jdgordon) - Tuesday, 16 September 2008, 10:32 GMT+2
|
Detailsthis patch is a WIP to update the bookmark system.
the change is to save "resume points" into the current .playlist_control file and copy that as a .bmark file. Right now it works fine to load and save (And even list the bookmark resume points). What doesn't work yet (in bmark.3.diff) is the recent bookmarks menu item. So far, the only downside I have found is that when you open a .bmark file the current playlist has to be stopped (it gets bookmarked automatically so if you cancel the .bmark it will resume anyway). I'm hopeing that this isnt a big enough issue to reject the patch. 
bmark.3.diff
(20.3 KiB)
apps/misc.h | 1 apps/playlist.c | 137 +++++++++++++++++++++++++++++++++++++++++++++++ apps/playlist.h | 21 +++++++ apps/onplay.c | 71 ------------------------ apps/filetree.c | 5 + apps/bookmark.c | 160 +++++++++++++++++++++++++++++++++++--------------------- apps/misc.c | 73 +++++++++++++++++++++++++ 7 files changed, 338 insertions(+), 130 deletions(-) |
This task depends upon
also, autoload from the filebrowser should work like svn (so even if the bookmark only has one point it will still show the listing (unless we want to get rid of that?) )
* Restore of playlist seed, shuffle on/off and repeat mode (seed and shuffle are very important, IMO).
* Display resume index (nice, but not as important).
* Display resume time in minutes:seconds (important too, if you have multiple bookmarks for a file).
And looking at the code, it seems the list is limited to 10 bookmarks.
the other two points are either fixed in 5, or will be in 6 which I'll upload in a few hours.
and yeah, should have mentinoed that you need to create with the WPS context menu... autocreating isnt done, and recent bmarks also isnt done.
thanks for testing
I've also removed almost all the old code to make it a bit easier to work with. lots of TODO's if anyone wants to help out.
I'm not sure how I want to implement the recent bookmarks without stealing either lots of ram, or hitting the disk, suggestions welcome.
autocreating bookmarks if its set to "yes"
this version adds talking bmark list.
suggestions on how to do the recent bookmark list???
Been away for the past fortnight so not yet had time to look at any of this, but I'd suggest that (long-term) the recent bookmarks list should be a more-general "recent stuff" list, i.e. not be tied into bookmarks at all. (I personally don't use bookmarks much, but would like to be able to just see the last n files I selected...).
This might be worth considering at this point, if not entirely OT.
The other option is creating the bookmark in the playback thread but I decided thats a bad idea because pausing there for user input is probably a Bad Thing (TM)
The default behavior could be to just resume right where you left off, with the alternative options to backstep 5 seconds or 10 seconds (or perhaps some other figure, but I think 10 seconds seems about right). Probably the way to do it is with a jumpback variable (0, 5, or 10 seconds) which would be subtracted from the current position (in seconds) prior to creation of the bookmark, checking, of course, that we don't rewind past the beginning of the file. This might be a good place to add in such a feature while bookmarking is getting re-worked.
There are a few TODO's still in the patch, but im not sure what else is missing... so test please.