Rockbox

Tasklist

FS#9408 - remove global_status.random_seed which I beleive isnt actually needed, NEEDS TESTING

Attached to Project: Rockbox
Opened by Jonathan Gordon (jdgordon) - Wednesday, 17 September 2008, 08:28 GMT
Last edited by Jonathan Gordon (jdgordon) - Saturday, 20 September 2008, 15:26 GMT
Task Type Patches
Category Playlists
Status Closed
Assigned To No-one
Operating System All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

this patch removes some code dealing with reloading the random seed from the global_status which I'm fairly certain was dead code...

in my quick testing with this patch with shuffling both with the menu option and in the quickscreen I can resume the playlist as it was correctly.

this patch also reclaims 4 bytes from the hwcodec nvram targets (and will invalidate your current playlist resume info)
This task depends upon

Closed by  Jonathan Gordon (jdgordon)
Saturday, 20 September 2008, 15:26 GMT
Reason for closing:  Accepted
Comment by Magnus Holmgren (learman) - Thursday, 18 September 2008, 18:35 GMT
Hm, yes, it does look like actually comes from the playlist_control file, using the PLAYLIST_COMMAND_SHUFFLE command... If so, it should be safe to remove.

Loading...