Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#9456 - Remove Repeat:Shuffle option and always reshuffle when Shuffle:Yes and Repeat:All

Attached to Project: Rockbox
Opened by William Poetra Yoga Hadisoeseno (wpyh) - Sunday, 05 October 2008, 06:28 GMT+2
Task Type Patches
Category Playlists
Status Unconfirmed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 0%
Private No

Details

This patch removes the Repeat:Shuffle setting, and always reshuffles the playlist when Shuffle is set to yes and Repeat is set to All.

The rationale behind this is that a user would rarely want to shuffle the playlist the first time only and always repeat the same sequence afterwards. Rather, one would either play the playlist in order and repeat in the same order, or shuffle the playlist first and always reshuffle.

Setting combinations affected:
- Shuffle:Yes && Repeat:All
before: shuffle the playlist but repeats the same sequence
after: shuffle the playlist and reshuffles when the end is reached
- Shuffle:Yes && Repeat:Shuffle
before: shuffle the playlist and reshuffles when the end is reached
after: this combination is replaced by Shuffle:Yes && Repeat:All
- Shuffle:No && Repeat:Shuffle
before: reshuffle when the end is reached
after: rarely used combination, not available anymore
All other combinations are not affected.

The patch contains some comment fixes and some code simplification as well. We also have to handle a special case in the patch.
   playlist_shuffle.v1.diff (7.1 KiB) 
 playlist.c        |   62 +++++++++++++++++++++++++++++-------------------------
 playlist.h        |    2 -
 playlist_viewer.c |    2 -
 settings.h        |    3 --
 settings_list.c   |    9 +++----
 5 files changed, 41 insertions(+), 37 deletions(-)

This task depends upon

Comment by William Poetra Yoga Hadisoeseno (wpyh) - Friday, 10 October 2008, 20:16 GMT+2
Sorry, the previous patch doesn't apply cleany. Please try this new patch.
   playlist_shuffle.v2.diff (7.2 KiB) 
 apps/playlist.c        |   62 ++++++++++++++++++++++++++-----------------------
 apps/playlist.h        |    2 -
 apps/settings.h        |    3 --
 apps/playlist_viewer.c |    2 -
 apps/settings_list.c   |    9 +++----
 5 files changed, 41 insertions(+), 37 deletions(-)

Comment by Jonathan Gordon (jdgordon) - Friday, 31 October 2008, 07:21 GMT+2
patch applies but doesnt compile
Comment by William Poetra Yoga Hadisoeseno (wpyh) - Thursday, 25 December 2008, 15:25 GMT+2
This is a new patch sync'ed to the latest svn, and I removed a code change that tests for CONFIG_CODEC.

jdgordon: Sorry for not updating the status. The patch compiles cleanly on my side. Could you please try the new patch? If it still fails to compile, please post the target you are building for and the error message here.
   playlist_shuffle.v3.diff (6.8 KiB) 
 apps/playlist.c        |   62 ++++++++++++++++++++++++++-----------------------
 apps/playlist.h        |    2 -
 apps/settings.h        |    1 
 apps/playlist_viewer.c |    2 -
 apps/settings_list.c   |    9 +++----
 5 files changed, 40 insertions(+), 36 deletions(-)

Comment by William Poetra Yoga Hadisoeseno (wpyh) - Sunday, 10 May 2009, 05:10 GMT+2
Sync'ed patch to latest SVN.
   playlist_shuffle.v5.diff (7.2 KiB) 
 apps/playlist.c        |   62 ++++++++++++++++++++++++++-----------------------
 apps/playlist.h        |    2 -
 apps/gui/statusbar.c   |    1 
 apps/settings.h        |    1 
 apps/playlist_viewer.c |    2 -
 apps/settings_list.c   |    9 +++----
 6 files changed, 40 insertions(+), 37 deletions(-)

Comment by William Poetra Yoga Hadisoeseno (wpyh) - Sunday, 17 May 2009, 17:38 GMT+2
Per discussion on IRC, now I would like to submit a smaller patch instead: Make Shuffle:Yes and Repeat:All behave the same as Repeat:Shuffle. This means that if Shuffle:Yes and Repeat:All, then at the end of the playlist, the playlist will be reshuffled.
   playlist_shuffle.v6.diff (1.4 KiB) 
 apps/playlist.c |   14 ++++++++++++--
 1 file changed, 12 insertions(+), 2 deletions(-)

Loading...