Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#9480 - reorganise and centralise the app layer event enums

Attached to Project: Rockbox
Opened by Jonathan Gordon (jdgordon) - Sunday, 12 October 2008, 11:41 GMT+2
Last edited by Jonathan Gordon (jdgordon) - Thursday, 16 October 2008, 12:38 GMT+2
Task Type Patches
Category Operating System/Drivers
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

currently the event class definitions are in export/events.h and sort of used randomly around the code... This patch moves all the different app layer events into a single .h so there is no chance that new events will accidentally use existing ones.

further cleanup:
get rid of ata_idle_notify and use events properly for this.
rename the buffering events to be constant with the others CLASS_EVENT_BLAA..

later: actually implement the theme changed event!
   event_changes.diff (7.1 KiB) 
 apps/gui/statusbar.h      |    4 ---
 apps/gui/gwps.c           |    3 +-
 apps/menus/display_menu.c |    4 +--
 apps/appevents.h          |   55 ++++++++++++++++++++++++++++++++++++++++++++++
 apps/mpeg.c               |    2 -
 apps/playback.c           |    2 -
 apps/buffering.c          |    2 -
 apps/buffering.h          |   10 --------
 apps/scrobbler.c          |    1 
 apps/tagtree.c            |    2 -
 firmware/export/events.h  |   15 +++---------
 11 files changed, 69 insertions(+), 31 deletions(-)

This task depends upon

Closed by  Jonathan Gordon (jdgordon)
Thursday, 16 October 2008, 12:38 GMT+2
Reason for closing:  Accepted

Loading...