Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#9515 - customizable quickscreen!

Attached to Project: Rockbox
Opened by Jonathan Gordon (jdgordon) - Thursday, 30 October 2008, 11:51 GMT+2
Last edited by Jonathan Gordon (jdgordon) - Monday, 03 November 2008, 12:11 GMT+2
Task Type Patches
Category Settings
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

this lets you choose which 3 settings you want in the quickscreen.
The new quickscreen items menu has been put under "settings > general settings > "Quickscreen Items".

This patch lets almost all settings which are accessible from the menu to be used. Unfortunately the EQ setting names aren't unique so in the setting screen the options are shown as "translated name (config name)".

from an e200 build:
svn:
Binary size: 574464
Actual size: 573384
RAM usage: 1421488

patched:
Binary size: 575488
Actual size: 574648
RAM usage: 1422784
   custom_quickscreen.1.diff (11.9 KiB) 
 apps/lang/english.lang     |   68 +++++++++++++++++++++++
 apps/gui/quickscreen.c     |  128 +++++++++++++++++++++++++++++++++++++++++++--
 apps/gui/quickscreen.h     |    2 
 apps/settings.h            |    6 ++
 apps/menus/settings_menu.c |   22 +++++++
 apps/menus/main_menu.c     |    1 
 apps/settings_list.c       |   10 +++
 apps/settings_list.h       |    3 -
 8 files changed, 233 insertions(+), 7 deletions(-)

This task depends upon

Closed by  Jonathan Gordon (jdgordon)
Monday, 03 November 2008, 12:11 GMT+2
Reason for closing:  Accepted
Comment by Jonathan Gordon (jdgordon) - Thursday, 30 October 2008, 14:46 GMT+2
new version. havnt checked the deltas because im too tired and its not commitable anyway.

this patch will give some warnings in settings_list.c, i need to fix the macro but dont see the problem now (12.45am)
saves and loads as the settings config name in the .cfg, stored in global_settings as an int.

line lengths need fixing probably.
also the QS drawing needs looking into (i think)... got some wierd placements before but forgot with which settings
   custom_quickscreen.2.diff (17.2 KiB) 
 apps/settings.c            |   13 ++++
 apps/lang/english.lang     |   68 ++++++++++++++++++++++
 apps/gui/quickscreen.c     |  138 +++++++++++++++++++++++++++++++++++++++++++--
 apps/gui/quickscreen.h     |    2 
 apps/settings.h            |    6 +
 apps/menus/settings_menu.c |   22 +++++++
 apps/menus/main_menu.c     |    1 
 apps/settings_list.c       |   61 +++++++++++++++++++
 apps/settings_list.h       |   14 ++++
 9 files changed, 318 insertions(+), 7 deletions(-)

Comment by Jonathan Gordon (jdgordon) - Friday, 31 October 2008, 06:53 GMT+2
OK, I think this is ready to commit...
I've split the patch into 2 diffs, custom_setting_type.diff adds the code needed to add settings which can read/write arbitrary stuff to the .cfg and load it accordingly.

One important thing to understand is that not every setting will work brilliantly in the quickscreen (without a bit of fiddling...) If the setting has a callback then that will be called when the value changes and it should work well, the settings which dont have a callback wont be set untill settings_apply() is called when the screen is exited. I'm leaving the handling for the default values because they wont work without special handling anyway and its there so may as well leave it.

just checked voicing and that works also :)
   custom_setting_type.diff (4.7 KiB) 
 apps/settings.c      |   15 +++++++++++++++
 apps/settings_list.c |    8 ++++++++
 apps/settings_list.h |   14 +++++++++++++-
 3 files changed, 36 insertions(+), 1 deletion(-)

   custom_quickscreen.3.diff (11.9 KiB) 
 apps/lang/english.lang     |   68 ++++++++++++++++++++++
 apps/gui/quickscreen.c     |  139 ++++++++++++++++++++++++++++++++++++++++++---
 apps/gui/quickscreen.h     |    2 
 apps/settings.h            |    6 +
 apps/menus/settings_menu.c |   22 +++++++
 apps/settings_list.c       |   53 +++++++++++++++++
 6 files changed, 281 insertions(+), 9 deletions(-)

Loading...