Index: apps/lang/english.lang =================================================================== --- apps/lang/english.lang (revision 18933) +++ apps/lang/english.lang (working copy) @@ -12109,3 +12109,71 @@ *: "Search Results" + + id: LANG_QS_ITEMS + desc: used for the submenu name for the quickscreen items + user: + + *: none + quickscreen: "Quickscreen Items" + + + *: none + quickscreen: "Quickscreen Items" + + + *: none + quickscreen: "Quickscreen Items" + + + + id: LANG_LEFT + desc: used for the submenu name for the quickscreen items + user: + + *: none + quickscreen: "Left" + + + *: none + quickscreen: "Left" + + + *: none + quickscreen: "Left" + + + + id: LANG_RIGHT + desc: used for the submenu name for the quickscreen items + user: + + *: none + quickscreen: "Right" + + + *: none + quickscreen: "Right" + + + *: none + quickscreen: "Right" + + + + id: LANG_BOTTOM + desc: used for the submenu name for the quickscreen items + user: + + *: none + quickscreen: "Bottom" + + + *: none + quickscreen: "Bottom" + + + *: none + quickscreen: "Bottom" + + Index: apps/gui/quickscreen.c =================================================================== --- apps/gui/quickscreen.c (revision 18933) +++ apps/gui/quickscreen.c (working copy) @@ -37,6 +37,7 @@ #include "audio.h" #include "quickscreen.h" #include "talk.h" +#include "list.h" static struct viewport vps[NB_SCREENS][QUICKSCREEN_ITEM_COUNT]; static struct viewport vp_icons[NB_SCREENS]; @@ -111,7 +112,7 @@ { /* scrolling needed */ int center = (parent->width - CENTER_ICONAREA_WIDTH)/2; - int width = MIN(center, MIN(left_width, right_width)); + int width = MAX(center, MIN(left_width, right_width)); vps[screen][QUICKSCREEN_LEFT].width = width; vps[screen][QUICKSCREEN_RIGHT].width = width; vps[screen][QUICKSCREEN_RIGHT].x = parent->x+parent->width - width; @@ -331,23 +332,39 @@ cond_talk_ids_fq(VOICE_OK); return changed; } - +static bool is_setting_quickscreenable(const struct settings_list *setting); bool quick_screen_quick(int button_enter) { struct gui_quickscreen qs; bool oldshuffle = global_settings.playlist_shuffle; int oldrepeat = global_settings.repeat_mode; - qs.items[QUICKSCREEN_LEFT] = + if (global_settings.qs_item_left != -1 && + global_settings.qs_item_left < nb_settings && + is_setting_quickscreenable(&settings[global_settings.qs_item_left])) + qs.items[QUICKSCREEN_LEFT] = &settings[global_settings.qs_item_left]; + else + qs.items[QUICKSCREEN_LEFT] = find_setting(&global_settings.playlist_shuffle, NULL); - qs.items[QUICKSCREEN_RIGHT] = + if (global_settings.qs_item_right != -1 && + global_settings.qs_item_right < nb_settings && + is_setting_quickscreenable(&settings[global_settings.qs_item_right])) + qs.items[QUICKSCREEN_RIGHT] = &settings[global_settings.qs_item_right]; + else + qs.items[QUICKSCREEN_RIGHT] = find_setting(&global_settings.repeat_mode, NULL); - qs.items[QUICKSCREEN_BOTTOM] = + if (global_settings.qs_item_bottom != -1 && + global_settings.qs_item_bottom < nb_settings && + is_setting_quickscreenable(&settings[global_settings.qs_item_bottom])) + qs.items[QUICKSCREEN_BOTTOM] = &settings[global_settings.qs_item_bottom]; + else + qs.items[QUICKSCREEN_BOTTOM] = find_setting(&global_settings.dirfilter, NULL); qs.callback = NULL; if (gui_syncquickscreen_run(&qs, button_enter)) { settings_save(); settings_apply(false); + /* this all shuold be changed to using the settings callbacks */ /* make sure repeat/shuffle/any other nasty ones get updated */ if ( oldrepeat != global_settings.repeat_mode && (audio_status() & AUDIO_STATUS_PLAY) ) @@ -389,3 +406,104 @@ } #endif /* BUTTON_F3 */ +/* stuff to make the quickscreen configurable */ +static bool is_setting_quickscreenable(const struct settings_list *setting) +{ + /* to keep things simple, only settings which have a lang_id set are ok */ + if (setting->lang_id < 0 || (setting->flags&F_BANFROMQS)) + return false; + switch (setting->flags&F_T_MASK) + { + case F_T_BOOL: + return true; + case F_T_INT: + case F_T_UINT: + return (setting->RESERVED != NULL); + default: + return false; + } +} + +static const struct settings_list *find_setting_from_index(int index) +{ + int count = -1, i; + const struct settings_list *setting = &settings[0]; + for(i=0;ilang_id), setting->cfg_name); + return buffer; +} +static int quickscreen_setter_speak_item(int selected_item, void * data) +{ + (void)data; + return find_setting_from_index(selected_item)->lang_id; +} +static int quickscreen_setter_action_callback(int action, + struct gui_synclist *lists) +{ + (void)lists; + switch (action) + { + case ACTION_STD_OK: + /* ok, quit */ + return ACTION_STD_CANCEL; + } + return action; +} +int quickscreen_set_option(void *data) +{ + int valid_settings_count = 0; + int i, newval = 0, oldval, *setting = NULL; + struct simplelist_info info; + switch ((intptr_t)data) + { + case QUICKSCREEN_LEFT: + setting = &global_settings.qs_item_left; + break; + case QUICKSCREEN_RIGHT: + setting = &global_settings.qs_item_right; + break; + case QUICKSCREEN_BOTTOM: + setting = &global_settings.qs_item_bottom; + break; + } + oldval = *setting; + for(i=0;i