Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#9527 - irc reader broken for ff3

Attached to Project: Rockbox
Opened by Alexander Papst (DerPapst) - Tuesday, 04 November 2008, 18:26 GMT+2
Last edited by Björn Stenberg (zagor) - Wednesday, 05 November 2008, 12:48 GMT+2
Task Type Patches
Category User Interface
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

This patch fixes a CSS issue introduced with the last irc reader update which makes the live log almost unreadable in FF3 at least.

Additionally it escapes 2 minuses into −− to avoid bricking the live log if someone posts --Delimeter or similar magic in the irc channel (see http://www.rockbox.org/irc/log-20081104).

Tested and works :)
This task depends upon

Closed by  Björn Stenberg (zagor)
Wednesday, 05 November 2008, 12:48 GMT+2
Reason for closing:  Accepted
Additional comments about closing:  Delimiter regex accepted.

Javascript changes rejected. That span is definitely not a table row.
Comment by Alexander Papst (DerPapst) - Tuesday, 04 November 2008, 18:27 GMT+2
Wait.. there was something to attach wasn't there?
   irc_reader.diff (1.3 KiB) 
 irc/reader.pl |    4 +++-
 irc/reader.js |    4 ++--
 2 files changed, 5 insertions(+), 3 deletions(-)

Comment by Alexander Papst (DerPapst) - Tuesday, 04 November 2008, 19:48 GMT+2
Oops :-)
Forgot to change one line.
   irc_reader.diff (1.6 KiB) 
 irc/reader.pl |    4 +++-
 irc/reader.js |    6 +++---
 2 files changed, 6 insertions(+), 4 deletions(-)

Comment by Peter D'Hoye (petur) - Wednesday, 05 November 2008, 11:45 GMT+2
irc reader works fine in minefield (ff3.1 beta2)
Comment by Rafaël Carré (funman) - Wednesday, 05 November 2008, 11:57 GMT+2
and fine in 3.0°.3 (although it didn't use to?)
   ffox303.png (67.9 KiB)

Loading...