- Status Closed
- Percent Complete
- Task Type Patches
- Category User Interface → Language
-
Assigned To
rasher - Operating System All players
- Severity Low
- Priority Very Low
- Reported Version Daily build (which?)
- Due in Version Undecided
-
Due Date
Undecided
- Votes
- Private
FS#9553 - Catalan Language adds
Catalan language adds
Closed by rasher
2008-12-13 01:54
Reason for closing: Accepted
Additional comments about closing: Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407
2008-12-13 01:54
Reason for closing: Accepted
Additional comments about closing: Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407
Committed in revision 19412 with the
changes suggested by Tom Ross.
Loading...
Available keyboard shortcuts
- Alt + ⇧ Shift + l Login Dialog / Logout
- Alt + ⇧ Shift + a Add new task
- Alt + ⇧ Shift + m My searches
- Alt + ⇧ Shift + t focus taskid search
Tasklist
- o open selected task
- j move cursor down
- k move cursor up
Task Details
- n Next task
- p Previous task
- Alt + ⇧ Shift + e ↵ Enter Edit this task
- Alt + ⇧ Shift + w watch task
- Alt + ⇧ Shift + y Close Task
Task Editing
- Alt + ⇧ Shift + s save task
Looks pretty good; some comments:
1. Shouldn’t the be a colon after the dest of LANG_ALBUMART?
2. Some items seem to have two spaces (e.g. LANG_LEFT_QS_ITEM). Is this intentional?
3. You seem to switch casing a bit in the language file and use title case in certain strings. From my understanding, this is common in American English but I wouldn’t expect it to be in Catalan. In particular, I’m looking at LANG_RESET_SETTING, LANG_SEARCH_RESULTS, and LANG_RECORDING_MONO_MODE.
Could the submitter or another Catalan speaker please answer the questions posted?
If that doesn’t happen within a reasonable time, it’s probably safe to commit anyway.