- Status Closed
- Percent Complete
- Task Type Patches
- Category Applications
- Assigned To No-one
- Operating System All players
- Severity Low
- Priority Very Low
- Reported Version Daily build (which?)
- Due in Version Undecided
-
Due Date
Undecided
- Votes
- Private
FS#9557 - Correctly interpret the number parameter of the %mv wps tag
The number parameter in the %mv tag (volume changing) should be interpreted as seconds. But it’s interpreted as 0.1 secs. I.e. 2.5 will wait 0.25 secs instead of 2.5. The patch fixes that.
Loading...
Available keyboard shortcuts
- Alt + ⇧ Shift + l Login Dialog / Logout
- Alt + ⇧ Shift + a Add new task
- Alt + ⇧ Shift + m My searches
- Alt + ⇧ Shift + t focus taskid search
Tasklist
- o open selected task
- j move cursor down
- k move cursor up
Task Details
- n Next task
- p Previous task
- Alt + ⇧ Shift + e ↵ Enter Edit this task
- Alt + ⇧ Shift + w watch task
- Alt + ⇧ Shift + y Close Task
Task Editing
- Alt + ⇧ Shift + s save task
Another try (moved private symbols from .h to .c).
A comment for the reviewers: it might be better to store the timeout not in 0.1 sec units (as it’s done now) but directly in ticks (i.e. in 0.01 sec units). Then the interpreting code wouldn’t need to do any scaling. But in the WPS structure, the subline timeout is stored as an unsigned char. That would be too small for storing ticks, hence I left it in tenth of a second. I didn’t want to make the data structure bigger in size.