Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#9573 - radio cleanup, move actual radio interface back into firmware/

Attached to Project: Rockbox
Opened by Jonathan Gordon (jdgordon) - Monday, 24 November 2008, 12:49 GMT+2
Last edited by Jonathan Gordon (jdgordon) - Sunday, 06 June 2010, 15:13 GMT+2
Task Type Patches
Category FM Tuner
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Release 3.0
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

The aim here is to eventually get recorder/radio.c to a state where its not painful to work with (and maybe a ui fixup later).

This moves the radio frequency/mono/station stuff into firmware/fmradio.c so apps/recorder/radio.c is more concerned with just drawing the screen and setting the radio to the station.

there is a yield() in radio_start() which should be removed somehow? and still more in radio.c which should be moved out. (Does apps/ need to know the fm region details?)
   radio_cleanup.1.diff (22.8 KiB) 
 apps/recorder/radio.c               |  172 ++++++------------------------------
 apps/recorder/radio.h               |    7 -
 apps/recorder/recording.c           |    2 
 apps/settings_list.c                |    3 
 apps/status.c                       |    4 
 firmware/export/tuner.h             |    9 -
 firmware/export/fmradio.h           |   32 +++++-
 firmware/export/fmradio_serial.h    |   19 ---
 firmware/SOURCES                    |    3 
 firmware/powermgmt.c                |    2 
 firmware/drivers/fmradio.c          |  121 -------------------------
 firmware/drivers/tuner/s1a0903x01.c |   26 ++---
 firmware/tuner.c                    |    9 -
 13 files changed, 80 insertions(+), 329 deletions(-)

This task depends upon

Closed by  Jonathan Gordon (jdgordon)
Sunday, 06 June 2010, 15:13 GMT+2
Reason for closing:  Out of Date

Loading...