Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#9579 - Fix compilation when build directory is not inside rockbox source directory

Attached to Project: Rockbox
Opened by Bartosz Fabianowski (undo) - Wednesday, 26 November 2008, 04:45 GMT+2
Last edited by Nils Wallménius (nls) - Wednesday, 26 November 2008, 10:43 GMT+2
Task Type Bugs
Category Build environment
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

The most recent change to wps/wpsbuild.pl introduced a bug that makes "make zip" fail if the build directory is not directly inside the rockbox source directory. The attached patch fixes this.

The problem is that $firmdir is set to "$ROOT/firmware" before the final value of $ROOT has been determined using GetOptions(). This way, $firmdir always is "../firmware", regardless of the root directory passed in via the -r option.
   patch_wpsbuild.pl (0.4 KiB)
This task depends upon

Closed by  Nils Wallménius (nls)
Wednesday, 26 November 2008, 10:43 GMT+2
Reason for closing:  Accepted
Additional comments about closing:  committed, thanks!

Loading...