Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#9583 - periodic table

Attached to Project: Rockbox
Opened by Yifu Huang (yhuang) - Thursday, 27 November 2008, 22:52 GMT+2
Task Type Patches
Category Plugins
Status Unconfirmed
Assigned To No-one
Player Type iPod 5G
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 0%
Private No

Details

I found this app useful in iPodLinux so I decided to port it to Rockbox. Jonathan Bettencourt is the original author.

Works on daily build: 19242 for iPod Video

Smaller screen targets won't be able to see the full table.
   periodic.diff (17.6 KiB) 
 apps/plugins/CATEGORIES |    1 
 apps/plugins/periodic.c |  465 ++++++++++++++++++++++++++++++++++++++++++++++++
 apps/plugins/SOURCES    |    1 
 3 files changed, 467 insertions(+)

   dump 081127-165027.bmp (150.1 KiB)
This task depends upon

Comment by Yifu Huang (yhuang) - Friday, 28 November 2008, 00:54 GMT+2
Removed the ugly boxes..
   periodic.diff (18.1 KiB) 
 apps/plugins/CATEGORIES |    1 
 apps/plugins/periodic.c |  477 ++++++++++++++++++++++++++++++++++++++++++++++++
 apps/plugins/SOURCES    |    1 
 3 files changed, 479 insertions(+)

   dump 081127-184130.bmp (150.1 KiB)
Comment by Yifu Huang (yhuang) - Friday, 28 November 2008, 01:45 GMT+2
Removed the ugly boxes..
   periodic.diff (18.1 KiB) 
 apps/plugins/CATEGORIES |    1 
 apps/plugins/periodic.c |  477 ++++++++++++++++++++++++++++++++++++++++++++++++
 apps/plugins/SOURCES    |    1 
 3 files changed, 479 insertions(+)

   dump 081127-184130.bmp (150.1 KiB)
Comment by Thomas Schott (scotty) - Monday, 01 December 2008, 13:22 GMT+2
Replaced strlen() calls by rb->strlen() to make it compile for ARM targets.
Fixed 2 warnings ("function declaration isn’t a prototype").
   periodic.diff (18.1 KiB) 
 apps/plugins/CATEGORIES |    1 
 apps/plugins/periodic.c |  477 ++++++++++++++++++++++++++++++++++++++++++++++++
 apps/plugins/SOURCES    |    1 
 3 files changed, 479 insertions(+)

Comment by Antoine Cellerier (dionoea) - Sunday, 07 December 2008, 17:25 GMT+2
Current policy is to only accept plugins that work on all targets (or on color targets for those that obviously couldn't work on black and white screens). Would it be possible to make the screen scroll so it could work on smaller screens? Thanks.
Comment by lorenzo (ltlollo) - Monday, 19 January 2009, 14:21 GMT+2
If compiled for Ipod Video, on 3.1 sources, some informations on the table are missing; on uisimulator the infos are present.
   dump 090119-141614.bmp (150.1 KiB)
   UISIMdump 090119-141917.bmp (150.1 KiB)
Comment by Yoshihisa Uchida (Uchida) - Tuesday, 27 January 2009, 10:22 GMT+2
In periodic plugin, there is the following problems:
- Build of this plugin fail under the current version Rockbox.
- It does not customize for players other than iPod video.
- The source code doesn't follow the Rockbox coding rule. ("//" comment, using TAB)
- Physical data of elements (mass, dencity, freezing point, and boiling point) is old.
- I do not understand whether it is uncertain data or the value of data is 0 because uncertain data is output by 0.

I corrected the source of this plugin in place of Huang.
The problem of lorenzo is solved by this correction.

changes:
- Build of this plugin success under the current version Rockbox.
- Current Rockbox build player (http://build.rockbox.org/) supports (excepts Archos Player).
(I check actual iPod video. Other players checked by using uisimulator.
- TAB -> 4 spaces, // coments -> /* comments */
- Physical data of elements update.
- Physical data changes float to char *.
- Uncertain data outputs by "-".
- Element has no stable nuclides. The value enclosed in brackets. (except Th, Pa, and U)
- Lantanoids include "La", Actinoids include "Ac" (tables place move)
- The 117th element does not display.
   periodic_new.patch (31.9 KiB) 
 b/apps/plugins/CATEGORIES |    1 
 b/apps/plugins/SOURCES    |    1 
 b/apps/plugins/periodic.c |  713 ++++++++++++++++++++++++++++++++++++++++++++++
 3 files changed, 715 insertions(+)

Comment by Rosso Maltese (asettico) - Tuesday, 03 March 2009, 15:59 GMT+2
Resync (just offset lines)
   plugins-9583periodic_new-v6.1.patch (31.9 KiB) 
 b/apps/plugins/CATEGORIES |    1 
 b/apps/plugins/SOURCES    |    1 
 b/apps/plugins/periodic.c |  713 ++++++++++++++++++++++++++++++++++++++++++++++
 3 files changed, 715 insertions(+)

Comment by Seth (froggyman) - Saturday, 11 April 2009, 02:59 GMT+2
needs re-syncing, i believe
Comment by Gman (Thecoolgman) - Wednesday, 15 April 2009, 02:51 GMT+2
Oh yes it dose
Comment by Yoshihisa Uchida (Uchida) - Thursday, 16 April 2009, 15:30 GMT+2
sync r20712.
   periodic_new_2.patch (31.9 KiB) 
 b/apps/plugins/CATEGORIES |    1 
 b/apps/plugins/SOURCES    |    1 
 b/apps/plugins/periodic.c |  713 ++++++++++++++++++++++++++++++++++++++++++++++
 3 files changed, 715 insertions(+)

Comment by Rosso Maltese (asettico) - Saturday, 17 October 2009, 11:26 GMT+2
Sync to r23221.
   plugins-9583periodic_new-v6.1.patch (31.9 KiB) 
 b/apps/plugins/CATEGORIES |    1 
 b/apps/plugins/SOURCES    |    1 
 b/apps/plugins/periodic.c |  713 ++++++++++++++++++++++++++++++++++++++++++++++
 3 files changed, 715 insertions(+)

Comment by Johannes Schwarz (Ubuntuxer) - Sunday, 18 October 2009, 12:21 GMT+2
In my opionion a informative periodic table is very useful, but there is still some work, before it can be committed.

The plugin have to work on stable ports as well as unstable ports, so I add some button macros. Meanwhile the plugin doesn't work on the c200, because of the small display size. I can't figure out, how to solve this.
But also on the e200 the font is almost unreadable. Perhaps it should be turned, because on the fuze it looks pretty good, although just high and width size is swapped.

Besides the application needs an manual.
For what is the button PERIODIC_KEY_SELECT ?

@asettico: Please use the the command "svn diff apps/plugins/ > patch.diff" to create a patch.
   periodic_new_3.diff (33.3 KiB) 
 apps/plugins/CATEGORIES |    1 
 apps/plugins/SOURCES    |    1 
 apps/plugins/periodic.c |  755 ++++++++++++++++++++++++++++++++++++++++++++++++
 3 files changed, 757 insertions(+)

Comment by Rosso Maltese (asettico) - Sunday, 18 October 2009, 12:44 GMT+2
Normally I use the command "svn diff", but in this case I fixed the patch more quickly simply modifying it, so the git format was unchanged. :-)
Comment by Thomas Schott (scotty) - Thursday, 11 November 2010, 01:07 GMT+2
Sync to r28551.
   FS9583-periodic_new_3-r28551.diff (33.2 KiB) 
 apps/plugins/CATEGORIES |    1 
 apps/plugins/SOURCES    |    1 
 apps/plugins/periodic.c |  753 ++++++++++++++++++++++++++++++++++++++++++++++++
 3 files changed, 755 insertions(+)

Loading...