Rockbox

Tasklist

FS#9599 - LCD Brightness setting broken by software fading

Attached to Project: Rockbox
Opened by Dave (dberg918) - Monday, 01 December 2008, 23:50 GMT
Last edited by Michael Sevakis (MikeS) - Tuesday, 02 December 2008, 02:58 GMT
Task Type Bugs
Category LCD
Status Closed
Assigned To No-one
Operating System Gigabeat F/X
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

When software fading was committed to SVN on November 26th (r19224 after some cleanup, r19221-19223 would not compile), the LCD brightness setting was broken. Whenever the brightness is changed in the LCD display menu and subsequently a button is pressed, the brightness returns to some default brightness setting. On my Gigabeat, the effect varies according to which level of brightness is selected. Anything above 5, and the brightness dims after button press. Anything below 5, the brightness increases a small amount after button press. Setting the brightness to 5 does nothing to the brightness after button press, as this must have been determined to be the default setting in some way.

The bug is still present in my current build of r19289.

The flyspray discussion for software fading can be found at  FS#6800 , or at this link:

http://www.rockbox.org/tracker/task/6800

This task depends upon

Closed by  Michael Sevakis (MikeS)
Tuesday, 02 December 2008, 02:58 GMT
Reason for closing:  Accepted
Additional comments about closing:  Patch works. Dave (dberg918) apparently had other issues related to hardware.
Comment by Thomas Martitz (kugel.) - Tuesday, 02 December 2008, 00:36 GMT
Try that. Report if it helps.
Comment by Dave (dberg918) - Tuesday, 02 December 2008, 01:16 GMT
This patch definitely helps, although there's still some funky stuff going on.

Everything works beautifully as long as the brightness setting isn't at 12 (maximum). When changing from 11 to 12, I noticed the brightness doesn't change quite as much as it does between all other numbers. Once the setting is changed to 12, when the button lights timeout, the lcd brightness jumps up a notch (up to what I assume 12 is supposed to be).

If you let the lcd timeout after that and then reactivate it, it will brighten all the way up to 12, and then jump back down to 11. Then when the button lights timeout again, it jumps back up. I also notice that when the lcd jump down to 11 occurs after lcd backlight activation, the button lights appear to get brighter.

Setting the button lights to timeout AFTER the lcd timeout will cause the jump to 12 in brightness to occur when the lcd dims. So it appears to get brighter before it dims on timeout. The button lights also appear to twitch when the lcd dims.

Sorry if this is hard to interpret...it has become a much more complex problem now, although much more subtle.
Comment by Robert Menes (RMenes379) - Tuesday, 02 December 2008, 01:59 GMT
Running r19295 here on my Gigabeat F. I can confirm that most of the issues Dave is having are also occuring on my Gigabeat as well.

Llorean has also mentioned that he encountered this issue on IRC as well.
Comment by Dave (dberg918) - Tuesday, 02 December 2008, 02:48 GMT
Okay, my previous comment can be ignored. I did my test while my Gigabeat was sitting in the dock, and my dock is kind of finicky. When it's out of the dock the patch works great!

Loading...