Rockbox

Tasklist

FS#9617 - Keymaps for Plugins fuze

Attached to Project: Rockbox
Opened by Frederick Full (fredddy) - Tuesday, 09 December 2008, 17:10 GMT
Last edited by MichaelGiacomelli (saratoga) - Thursday, 08 January 2009, 20:34 GMT
Task Type Patches
Category Plugins
Status Closed
Assigned To No-one
Operating System Another
Severity Low
Priority Normal
Reported Version Release 3.0
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Well the plugins compile for me in the Simulator.

Hope this helps
This task depends upon

Closed by  MichaelGiacomelli (saratoga)
Thursday, 08 January 2009, 20:34 GMT
Reason for closing:  Accepted
Comment by Robert Menes (RMenes379) - Tuesday, 09 December 2008, 17:27 GMT
The keymaps look very good. If one of the Fuze developers can try it out on the real hardware, we'll see about having this committed.
Comment by Frederick Full (fredddy) - Tuesday, 09 December 2008, 17:49 GMT
Well buttons aren`t working on the fuze so its not possible to try on a real fuze.
Comment by Frederick Full (fredddy) - Tuesday, 09 December 2008, 21:43 GMT
Just some cleaning
Comment by Frederick Full (fredddy) - Wednesday, 10 December 2008, 18:26 GMT
That should be all of them now
Comment by Rafaël Carré (funman) - Wednesday, 10 December 2008, 20:53 GMT
hello,

i noticed that some keymaps are the same than C200, any reason you wouldn't rather use the e200 (which has a scrollwheel like the fuze, unlike the C200)?

i noticed also some lines like:
+#if CONFIG_KEYPAD != SANSA_E200_PAD | SANSA_FUZE_PAD

I'm not sure if simple '|' has a meaning for C preprocessor

It rather should be like:
+#if CONFIG_KEYPAD != SANSA_E200_PAD && CONFIG_KEYPAD != SANSA_FUZE_PAD
Comment by Frederick Full (fredddy) - Thursday, 11 December 2008, 13:36 GMT
some plugins don`t use the schrollwheel on the e200 too so its the same keymap for c200, clip, fuze and the e200.

#if (CONFIG_KEYPAD != SANSA_E200_PAD) || (CONFIG_KEYPAD !=SANSA_FUZE_PAD)

I think it should work like this. In your way both SANSA_FUZE_PAD and SANSA_E200_PAD need to be false? but if one of them is true it would still compile without that code.
Comment by Rafaël Carré (funman) - Thursday, 11 December 2008, 13:43 GMT
No, it won't work, *_PAD are always defined to different (incremental) values

Your if is always true:

if CONFIG_KEYPAD == SANSA_E200_PAD the first part is false, but the 2nd is true (SANSA_E200_PAD != SANSA_FUZE_PAD) and so the whole if is true.
Comment by Frederick Full (fredddy) - Thursday, 11 December 2008, 19:13 GMT
okay your right my bad.

Hier is the new patch.

Comment by Rafaël Carré (funman) - Thursday, 11 December 2008, 21:21 GMT
Looks ok to me.

Did you try all the plugins by the way ? Some can look bad if they use bitmaps (I dont know if another target exists with the same screen size)

If some bitmaps need to be procuced, this can be done later and this patch should be committed what ever (bug someone to commit it).

thanks you !
Comment by Frederick Full (fredddy) - Saturday, 13 December 2008, 12:53 GMT
I´ll have some more time next week. Maybe we have buttons until then. Working on the real device would give a better feeling I`ll have a look on the bitmaps and buttons then.
Comment by Frederick Full (fredddy) - Monday, 22 December 2008, 12:47 GMT
Here is a patch for the current svn. You have to change tools/configure by yourself I don`t know if I should change that file.

I didn`t try all plugins on real hardware but I´ll do that now.
Comment by Eric Shattow (lucent) - Monday, 22 December 2008, 18:57 GMT
Tried above patch (2) on Sansa Fuze target.

Build Errors:

- No keymap for mandelbrot plugin (Typo: rename dupe'd E200 keymap chunk to FUZE)

Keymap Errors:

- Bubbles keymap is wrong (missed a chunk to update)

Corrected patch attached.
Comment by Thomas Martitz (kugel.) - Sunday, 04 January 2009, 22:50 GMT
Here's an updated version.

I added some FIXMEs here and there, which I think should be fixed in other patches, and I have plans to do it myself soon, but I won't stop anyone else from beating me.
Comment by Thomas Martitz (kugel.) - Sunday, 04 January 2009, 23:07 GMT
fix warnings in jewels.

Loading...