Rockbox

Tasklist

FS#9622 - Fix pictureflow segmentation fault on ipod video sim

Attached to Project: Rockbox
Opened by Akio Idehara (idak) - Wednesday, 10 December 2008, 12:52 GMT
Last edited by Jonas Häggqvist (rasher) - Friday, 12 December 2008, 19:40 GMT
Task Type Patches
Category Plugins
Status Closed
Assigned To No-one
Operating System iPod 5G
Severity Low
Priority Normal
Reported Version Release 3.0
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

pictureflow segmentation fault occurs on ipod video sim.
This cause is that
id3.albumartist and id3.artist is not
initialized with NULL before search_albumart_files().

This patch fix it.
This task depends upon

Closed by  Jonas Häggqvist (rasher)
Friday, 12 December 2008, 19:40 GMT
Reason for closing:  Accepted
Additional comments about closing:  Revision 19404 adds this - a proper fix (setting artist and albumartist to their correct values) still needs to be done.
Comment by Thomas Martitz (kugel.) - Friday, 12 December 2008, 18:15 GMT
I just wanted to confirm the issue on my e200 sim. The patch seems to help
Comment by Thomas Martitz (kugel.) - Friday, 12 December 2008, 18:33 GMT
I included you fix in  FS#8335 
Comment by Jonas Häggqvist (rasher) - Friday, 12 December 2008, 18:38 GMT
Ideally, id3.artist and id3.albumartist should be set to their actual values (to fix  FS#9606 ), but this is better than nothing, I suppose.

Loading...