Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#9623 - Fuze lcd driver fixes

Attached to Project: Rockbox
Opened by Thomas Martitz (kugel.) - Thursday, 11 December 2008, 17:43 GMT+2
Last edited by Dave Chapman (linuxstb) - Tuesday, 16 December 2008, 08:55 GMT+2
Task Type Patches
Category LCD
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Release 3.0
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

a) remove lcd_delay, doesn't seem to be needed (and I didn't find any such function in the 1.01.15 OF version)
b) add a lcd_write_cmd which I found in the OF
c) some fixes to lcd_update_rect
d) only execute lcd_enable if really needed
   lcd-fuze.c.vc.diff (3.1 KiB) 
 firmware/target/arm/as3525/sansa-fuze/lcd-fuze.c |   69 ++---------------------
 1 file changed, 8 insertions(+), 61 deletions(-)

This task depends upon

Closed by  Dave Chapman (linuxstb)
Tuesday, 16 December 2008, 08:55 GMT+2
Reason for closing:  Accepted
Additional comments about closing:  Committed as r19452.
Comment by Rafaël Carré (funman) - Thursday, 11 December 2008, 17:52 GMT+2
It looks ok to me, I'll just wait for your confirmation
Comment by Thomas Martitz (kugel.) - Thursday, 11 December 2008, 17:59 GMT+2
Ok, some small cleanup to lcd_init
   lcd-fuze.c.vc.diff (3.4 KiB) 
 firmware/target/arm/as3525/sansa-fuze/lcd-fuze.c |   78 ++---------------------
 1 file changed, 9 insertions(+), 69 deletions(-)

Comment by Thomas Martitz (kugel.) - Monday, 15 December 2008, 01:21 GMT+2
some more stuff:

add a mutex, so that lcd transfers are undisturbed (and they will be without by buttons)
add a small delay in lcd_enable to avoid irritating/epilepsy causing flash when called (i.e. at backlight on).

Someone volunteers to commit?
   lcd-fuze.c.vc.diff (4.8 KiB) 
 firmware/target/arm/as3525/sansa-fuze/lcd-fuze.c |  105 +++++++----------------
 1 file changed, 33 insertions(+), 72 deletions(-)

Comment by Thomas Martitz (kugel.) - Monday, 15 December 2008, 20:32 GMT+2
remove lcd_mutex alltogether, it's apprently not needed.
   lcd-fuze.c.vc.diff (4.1 KiB) 
 firmware/target/arm/as3525/sansa-fuze/lcd-fuze.c |   96 +++++------------------
 1 file changed, 23 insertions(+), 73 deletions(-)

Comment by MichaelGiacomelli (saratoga) - Tuesday, 16 December 2008, 03:42 GMT+2
Commited. I'll leave this open in case you make further changes.

Loading...