Rockbox

Tasklist

FS#9623 - Fuze lcd driver fixes

Attached to Project: Rockbox
Opened by Thomas Martitz (kugel.) - Thursday, 11 December 2008, 16:43 GMT
Last edited by Dave Chapman (linuxstb) - Tuesday, 16 December 2008, 07:55 GMT
Task Type Patches
Category LCD
Status Closed
Assigned To No-one
Operating System All players
Severity Low
Priority Normal
Reported Version Release 3.0
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

a) remove lcd_delay, doesn't seem to be needed (and I didn't find any such function in the 1.01.15 OF version)
b) add a lcd_write_cmd which I found in the OF
c) some fixes to lcd_update_rect
d) only execute lcd_enable if really needed
This task depends upon

Closed by  Dave Chapman (linuxstb)
Tuesday, 16 December 2008, 07:55 GMT
Reason for closing:  Accepted
Additional comments about closing:  Committed as r19452.
Comment by Rafaël Carré (funman) - Thursday, 11 December 2008, 16:52 GMT
It looks ok to me, I'll just wait for your confirmation
Comment by Thomas Martitz (kugel.) - Thursday, 11 December 2008, 16:59 GMT
Ok, some small cleanup to lcd_init
Comment by Thomas Martitz (kugel.) - Monday, 15 December 2008, 00:21 GMT
some more stuff:

add a mutex, so that lcd transfers are undisturbed (and they will be without by buttons)
add a small delay in lcd_enable to avoid irritating/epilepsy causing flash when called (i.e. at backlight on).

Someone volunteers to commit?
Comment by Thomas Martitz (kugel.) - Monday, 15 December 2008, 19:32 GMT
remove lcd_mutex alltogether, it's apprently not needed.
Comment by MichaelGiacomelli (saratoga) - Tuesday, 16 December 2008, 02:42 GMT
Commited. I'll leave this open in case you make further changes.

Loading...