Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#9627 - Pictureflow: 3 bugfixes

Attached to Project: Rockbox
Opened by Thomas Martitz (kugel.) - Friday, 12 December 2008, 21:48 GMT+2
Last edited by Jonas Häggqvist (rasher) - Friday, 12 December 2008, 22:29 GMT+2
Task Type Patches
Category Plugins
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Release 3.0
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

This patch fixes all remaining bugs I know about :

 FS#9606  - by getting the whole metadata, not only album
 FS#9135  - by explicitly removing existing cache before creating new one (i.e. that what the user had to do manually)
 FS#8347  - by not resetting the selection variable upon re-entering (now works as expected, i.e. not by dirty resetting tracklist)
   pf_bugfixes.diff (3.2 KiB) 
 apps/plugins/pictureflow.c |   31 +++++++++++++------------------
 1 file changed, 13 insertions(+), 18 deletions(-)

This task depends upon

Closed by  Jonas Häggqvist (rasher)
Friday, 12 December 2008, 22:29 GMT+2
Reason for closing:  Accepted
Additional comments about closing:  Committed in revision 19408.
Comment by Jonas Häggqvist (rasher) - Friday, 12 December 2008, 21:54 GMT+2
Your patch has a lot of seemingly unrelated scrollwheel-related changes. Please post a cleaner patch.
Comment by Thomas Martitz (kugel.) - Friday, 12 December 2008, 21:56 GMT+2
Then add this as a 4th bug fix.

The scrollwheel define in pf is homebrewed and doesn't use the existing HAVE_SCROLLWHEEL. Imagine the fuze gets supported, pf will be broken, even though you'd think everything is fine if you defined HAVE_SCROLLWHEEL.
Comment by Thomas Martitz (kugel.) - Friday, 12 December 2008, 22:11 GMT+2
Okok, take this one :)
   pf_bugfixes.diff (1.7 KiB) 
 apps/plugins/pictureflow.c |   14 ++++++++------
 1 file changed, 8 insertions(+), 6 deletions(-)

Loading...