Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#9634 - Pictureflow: fix FS#9135 (again, now really)

Attached to Project: Rockbox
Opened by Thomas Martitz (kugel.) - Saturday, 13 December 2008, 23:45 GMT+2
Last edited by Jonas Häggqvist (rasher) - Sunday, 14 December 2008, 01:40 GMT+2
Task Type Patches
Category Plugins
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Release 3.0
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

My fix that was committed yesterday for that worked during testing, until I moved the deletion a slight bit down in the function. I moved it down because snprintf'ing to this global variable is done several times in that function, and I needed to add just more snprintfs to make it keep it workign. That broke the fix again without me noticing.

The patch also cleans up this particular global var, which just confused me during resolving that bug.

Sorry for the inconveniences :(
   pf_bugfixes_take2.diff (2.2 KiB) 
 apps/plugins/pictureflow.c |   21 ++++++++++-----------
 1 file changed, 10 insertions(+), 11 deletions(-)

This task depends upon

Closed by  Jonas Häggqvist (rasher)
Sunday, 14 December 2008, 01:40 GMT+2
Reason for closing:  Accepted
Additional comments about closing:  Committed in revision 19432.
Comment by Thomas Martitz (kugel.) - Saturday, 13 December 2008, 23:57 GMT+2
Hmm, we agreed to not use MAX_PATH+1, so don't do it.
Comment by Thomas Martitz (kugel.) - Saturday, 13 December 2008, 23:57 GMT+2
with this one
   pf_bugfixes_take2.diff (2.4 KiB) 
 apps/plugins/pictureflow.c |   25 ++++++++++++-------------
 1 file changed, 12 insertions(+), 13 deletions(-)

Loading...