- Status Closed
- Percent Complete
- Task Type Bugs
- Category User Interface
- Assigned To No-one
- Operating System All players
- Severity Low
- Priority Very Low
- Reported Version Daily build (which?)
- Due in Version Undecided
-
Due Date
Undecided
- Votes
- Private
FS#9637 - Changing to a theme that uses a non-existing font causes text corruption.
On r19432, when loading a new theme that contains a font that doesn’t exist on the target player causes the player’s text to become corrupt. Doing the same actions on a target simulator causes the sim to crash.
After a restart of the player the default font is then loaded. I far as I know, the default font should have been loaded in the first place, but for some unknown reason doesn’t.
Tested on target Gigabeat F40, Gigabeat F sim, and iPod Video sim.
When I get a chance, I will be happy to upload a screenshot of the corruption and attempt to find which revision caused this bug.
Closed by nls
2008-12-14 10:16
Reason for closing: Accepted
Additional comments about closing: Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407
2008-12-14 10:16
Reason for closing: Accepted
Additional comments about closing: Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407
Patch committed, thanks!
Loading...
Available keyboard shortcuts
- Alt + ⇧ Shift + l Login Dialog / Logout
- Alt + ⇧ Shift + a Add new task
- Alt + ⇧ Shift + m My searches
- Alt + ⇧ Shift + t focus taskid search
Tasklist
- o open selected task
- j move cursor down
- k move cursor up
Task Details
- n Next task
- p Previous task
- Alt + ⇧ Shift + e ↵ Enter Edit this task
- Alt + ⇧ Shift + w watch task
- Alt + ⇧ Shift + y Close Task
Task Editing
- Alt + ⇧ Shift + s save task
Here is a screen dump showing the corruption:
Here is a small patch to fix the bug. The reason this was happening was because the theme loading code wasn’t checking if the font file existed or not. This patch inserts a check to see if the font_load function returns NULL (Font file doesn’t exist), if it does return NULL, then it resets the font settings.
This patch was tested on my Gigabeat F and does indeed fix the bug. Thanks!