Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#9638 - temp_cue is unused and wasting memory

Attached to Project: Rockbox
Opened by Boris Gjenero (dreamlayers) - Sunday, 14 December 2008, 07:20 GMT+2
Last edited by Bertrik Sikken (bertrik) - Saturday, 31 January 2009, 20:42 GMT+2
Task Type Patches
Category Music playback
Status Closed
Assigned To Nicolas Pennequin (nicolas_p)
Player Type All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

It seems that in the past there was an attempt to load up to two cue sheets into memory, using curr_cue for the current track, and temp_cue for an upcoming track. Currently temp_cue is allocated and never loaded with data, wasting 70k. In gwps-common.c, the current filename is compared with uninitialized memory in temp_cue, which probably doesn't cause problems but seems like a bad idea.

In this patch I've removed code relating to temp_cue.
   no_temp_cue.patch (4.8 KiB) 
 rockbox-19370-notempcue/apps/cuesheet.c                      |    3 -
 rockbox-19370-notempcue/apps/cuesheet.h                      |    1 
 rockbox-19370-notempcue/apps/gui/gwps-common.c               |   22 +++--------
 rockbox-19370-notempcue/apps/playback.c                      |   17 --------
 rockbox-19370-notempcue/utils/wpseditor/libwps/src/dummies.c |    1 
 rockbox-19370-notempcue/utils/wpseditor/libwps/src/dummies.h |    1 
 6 files changed, 7 insertions(+), 38 deletions(-)

This task depends upon

Closed by  Bertrik Sikken (bertrik)
Saturday, 31 January 2009, 20:42 GMT+2
Reason for closing:  Accepted
Additional comments about closing:  Committed as svn r19890

Loading...