Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#9644 - Build directory names containing ".c" or ".S" cause make to fail.

Attached to Project: Rockbox
Opened by Davide (Davide-NYC) - Monday, 15 December 2008, 01:13 GMT+2
Last edited by Björn Stenberg (zagor) - Monday, 15 December 2008, 11:02 GMT+2
Task Type Bugs
Category Build environment
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Release 3.0
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

When using sim directories that contain the strings ".c" or ".S" they get replaced with ".o" and the build process fails.

Example error message: make: *** No rule to make target `/home/Administrator/rockbox/sim.olip/uisimulator/sdl/button.o', needed by `/home/Administrator/rockbox/sim.clip/uisimulator/libuisimulator.a'. Stop.

Nils identified the problem at tools/functions.make:28
This task depends upon

Closed by  Björn Stenberg (zagor)
Monday, 15 December 2008, 11:02 GMT+2
Reason for closing:  Fixed
Additional comments about closing:  Fixed in r19443
Comment by Nils Wallménius (nls) - Monday, 15 December 2008, 01:15 GMT+2
further investigation showed that this substitution happens in 3 places.
The attached patch makes a build work again using basename and addsuffix to
strip suffixes and add ".o" to the basename, i'm not sure that's a good idea though
as it will add all kinds of files to the obj lists.

   makefix.diff (2 KiB) 
 tools/functions.make               |    2 +-
 apps/codecs/libspeex/libspeex.make |    2 +-
 apps/codecs/libmad/libmad.make     |    2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

Loading...