Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#9645 - Working buttons for Fuze

Attached to Project: Rockbox
Opened by Thomas Martitz (kugel.) - Monday, 15 December 2008, 01:33 GMT+2
Last edited by Björn Stenberg (zagor) - Wednesday, 31 December 2008, 22:03 GMT+2
Task Type Patches
Category Drivers
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Release 3.0
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

This patch enables at least some of the buttons for the main build.

It's based on domonoky's buttons for e200v2, but does it a bit better (imho), as it's
a) only changing the afsel and dir for the pins we need for the buttons -- and this GREATLY improves reliability of the lcd, as in it's working perfectly instead of showing crazy stuff on the screen (and doing this also avoids changing lcd_update_rect to lcd_update)
b) it uses mutex instead of disabling irqs. NOTE: The lcd_mutex comes from http://www.rockbox.org/tracker/task/9623 , so apply that one too. This mutex is needed anyway, else the buttons reads are going to mess up the lcd. This combo is tested and works well (for me of course).

I decided to remove the HAVE_SCROLLWHEEL define for now, until the scrollwheel actually works. The reason is that those defines disturb creating a reduced keymap which uses up/down to browse in lists.

I also added a reduced keymap, for testing purpose. It's lousy based on the c200 keymap, and lacks some features, but it makes browsing possible (and playing music). Add it to SOURCES (and remove the regular keymap) in case you use it.
   button-fuze.c.vc.diff (4.2 KiB) 
 firmware/target/arm/as3525/sansa-fuze/button-fuze.c |   89 ++++++++++----------
 firmware/export/config-fuze.h                       |    2 
 2 files changed, 50 insertions(+), 41 deletions(-)

   keymap-fuze-reduced.c (15.2 KiB)
This task depends upon

Closed by  Björn Stenberg (zagor)
Wednesday, 31 December 2008, 22:03 GMT+2
Reason for closing:  Accepted
Additional comments about closing:  Commited in r19629.
Comment by Eric Shattow (lucent) - Monday, 15 December 2008, 09:30 GMT+2
Tested r19442 with keymap-fuze-reduced.c, applied button-fuze.c.vc.diff and lcd-fuze.c.vc.diff ( FS#9623 ) on Fuze 8GB hardware. Display is reliable, button presses working for up / down / left / right / select.
Comment by Thomas Martitz (kugel.) - Monday, 15 December 2008, 12:35 GMT+2
Thanks for the feedback!

Does anyone have objections against this patch? I'd also be interested if the way I did it works well for e200v2 too.

BTW: I've so far not experienced any missed button press.
Comment by Thomas Martitz (kugel.) - Monday, 15 December 2008, 20:27 GMT+2
Remove lcd_mutex, it's apparently not needed.
Also updated some comments (and the copyright notice).
   button-fuze.c.vc.diff (5.1 KiB) 
 firmware/target/arm/as3525/sansa-fuze/button-fuze.c |  102 ++++++++++----------
 firmware/export/config-fuze.h                       |    2 
 2 files changed, 58 insertions(+), 46 deletions(-)

Comment by Eric Shattow (lucent) - Tuesday, 16 December 2008, 09:21 GMT+2
Cleaned up patch a bit and limited its scope to just fixing up the button code, does not touch scrollwheel or keymap. Tested successfully on 8GB Fuze in bootloader and normal builds.
   button-fuze.c.3.patch (4.7 KiB) 
 firmware/target/arm/as3525/sansa-fuze/button-fuze.c |   96 +++++++++-----------
 1 file changed, 47 insertions(+), 49 deletions(-)

Comment by Thomas Martitz (kugel.) - Tuesday, 16 December 2008, 20:14 GMT+2
make keymap usable for FM radio.

Note: this one is only supposed to make the Fuze/e200v2 usable. It's by no means meant to be a final keymap!
   keymap-fuze-reduced.c (15 KiB)
Comment by Eric Shattow (lucent) - Monday, 22 December 2008, 10:19 GMT+2
Tested patch (not listed above, attached for reference) as mentioned on IRC against r19555 to enable scrollwheel. Working on 8GB Fuze hardware are Scrollwheel (usable but it twitches a bit), Up / Down / Left / Right / Hold / Power buttons, and I don't know if "Home" button is mapped but it doesn't seem to do anything. Leaving comment here due to not being on IRC at the same time, anticipate this task to be updated soon by author.
   buttonwheel_almost_working-kugel.patch (14 KiB) 
 firmware/export/config-fuze.h                         |    2 
 firmware/target/arm/as3525/clock-target.h             |    2 
 firmware/target/arm/as3525/sansa-fuze/button-fuze.c   |  314 ++++++++++++++----
 firmware/target/arm/as3525/sansa-fuze/button-target.h |    6 
 firmware/target/arm/as3525/sansa-fuze/lcd-fuze.c      |    7 
 5 files changed, 260 insertions(+), 71 deletions(-)

Comment by Thomas Martitz (kugel.) - Wednesday, 24 December 2008, 06:19 GMT+2
Just as a note to the above patch: Yes, Home button is still not known how to read. And the scrollwheel is far from working reliable. We need to find a way to trigger an IRQ from the wheel, it won't get good using the tick task only.
Comment by Gabe Cook (gabe565) - Friday, 26 December 2008, 23:57 GMT+2
I tested it on my 8 GB Fuze, and the buttons work fine, except home of course. The scrollwheel, like Kugel said, is not very reliable. To move just one down or up, I have to carefully turn it. Great job so far, though!
Comment by Thomas Martitz (kugel.) - Wednesday, 31 December 2008, 01:13 GMT+2
Update: Wheel is working acceptable, still no Home button.

Reverted to e200 keymap, so that everything is usable (replaced Rec with Home).

This can go in.
   buttonwheel_almost_working-kugel.patch (23.3 KiB) 
 apps/keymaps/keymap-fuze.c                            |   77 ++---
 firmware/export/config-fuze.h                         |    2 
 firmware/target/arm/as3525/clock-target.h             |    2 
 firmware/target/arm/as3525/sansa-fuze/button-fuze.c   |  251 ++++++++++++------
 firmware/target/arm/as3525/sansa-fuze/button-target.h |   11 
 firmware/target/arm/as3525/sansa-fuze/lcd-fuze.c      |    7 
 firmware/target/arm/sandisk/sansa-e200/button-e200.c  |    2 
 7 files changed, 233 insertions(+), 119 deletions(-)

Comment by Thomas Martitz (kugel.) - Wednesday, 31 December 2008, 02:26 GMT+2
This one works slightly better.
   buttonwheel_almost_working-kugel-v3.patch (23.5 KiB) 
 apps/keymaps/keymap-fuze.c                            |   78 ++---
 firmware/export/config-fuze.h                         |    2 
 firmware/target/arm/as3525/clock-target.h             |    2 
 firmware/target/arm/as3525/sansa-fuze/button-fuze.c   |  251 ++++++++++++------
 firmware/target/arm/as3525/sansa-fuze/button-target.h |   11 
 firmware/target/arm/as3525/sansa-fuze/lcd-fuze.c      |    7 
 firmware/target/arm/sandisk/sansa-e200/button-e200.c  |    2 
 7 files changed, 233 insertions(+), 120 deletions(-)

Comment by Thomas Martitz (kugel.) - Wednesday, 31 December 2008, 02:48 GMT+2
Get rid of some oops/unrelated change, sorry :/
   buttonwheel_almost_working-kugel-v4.patch (21.7 KiB) 
 apps/keymaps/keymap-fuze.c                            |   77 ++---
 firmware/target/arm/as3525/clock-target.h             |    2 
 firmware/target/arm/as3525/sansa-fuze/button-fuze.c   |  251 ++++++++++++------
 firmware/target/arm/as3525/sansa-fuze/button-target.h |   11 
 4 files changed, 225 insertions(+), 116 deletions(-)

Loading...