Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#9661 - Quickscreen: Don't let the up button do anything

Attached to Project: Rockbox
Opened by Thomas Martitz (kugel.) - Wednesday, 17 December 2008, 18:01 GMT+2
Last edited by Marc Guay (Marc_Guay) - Tuesday, 30 December 2008, 21:40 GMT+2
Task Type Patches
Category User Interface
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Release 3.0
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

As per IRC talk, here's a patch that makes the up button don't do anything in the quickscreen.

The fact that the button changes the bottom item as well is unexpected (the quickscreen as is doesn't indicate at all that the up button is mapped) and is likely to lead to changed settings by accident.

IMHO this should get into the release for the reasons mentioned.

This patch doesn't touch the keymap files, as it doesn't harm if they still define a ACTION_QS_DOWNINV button. I think cleanup those up should be done after the release, just to be safe.
Or just keep those, so that if a 4th item is going to happen it's easier and faster (i.e. by search-and-replace) to define the button for the top item. You decide.

Doesn't change anything for Recorder as it seems to be required for those.
   quickscreen.c.vc.diff (0.4 KiB) 
 apps/gui/quickscreen.c |    2 ++
 1 file changed, 2 insertions(+)

This task depends upon

Closed by  Marc Guay (Marc_Guay)
Tuesday, 30 December 2008, 21:40 GMT+2
Reason for closing:  Rejected
Additional comments about closing:  See  FS#9706 
Comment by Dominik Riebeling (bluebrother) - Wednesday, 17 December 2008, 20:36 GMT+2
I really like the possibility to go "up" in the "down" item on my h100 and would hate to loose it. IMO it would be better to indicate that the bottom entry can also get changed that way.
Comment by Thomas Martitz (kugel.) - Wednesday, 17 December 2008, 20:47 GMT+2
Well, looks you're one of the very few thinking this way.

But even if we did it like you propose (it would be a possible fix too of course), we would lose the possibility for a 4th item, and JdGordon said he's at least planning on a 4th item (and that he definitely doesn't want the top part to be blocked).
Comment by Thomas Martitz (kugel.) - Tuesday, 23 December 2008, 18:17 GMT+2
Ok, do it a little cleaner
   quickscreen-no-up-button.diff (20.6 KiB) 
 apps/action.h                     |    5 +++--
 apps/gui/quickscreen.c            |    4 +++-
 apps/keymaps/keymap-sa9200.c      |    2 --
 apps/keymaps/keymap-m200.c        |    3 ---
 apps/keymaps/keymap-m3.c          |    4 ----
 apps/keymaps/keymap-touchscreen.c |    2 --
 apps/keymaps/keymap-creativezv.c  |    2 --
 apps/keymaps/keymap-h1x0_h3x0.c   |    8 --------
 apps/keymaps/keymap-ifp7xx.c      |    2 --
 apps/keymaps/keymap-clip.c        |    2 --
 apps/keymaps/keymap-iaudio67.c    |    3 ---
 apps/keymaps/keymap-h10.c         |    4 ----
 apps/keymaps/keymap-av300.c       |    2 --
 apps/keymaps/keymap-x5.c          |    4 ----
 apps/keymaps/keymap-creativezvm.c |    2 --
 apps/keymaps/keymap-mr100.c       |    2 --
 apps/keymaps/keymap-logikdax.c    |    3 ---
 apps/keymaps/keymap-gigabeat.c    |    2 --
 apps/keymaps/keymap-gigabeat-s.c  |    2 --
 apps/keymaps/keymap-c100.c        |    3 ---
 apps/keymaps/keymap-c200.c        |    3 ---
 apps/keymaps/keymap-e200.c        |    2 --
 apps/keymaps/keymap-meizu-m6sl.c  |    2 --
 apps/keymaps/keymap-hdd1630.c     |    2 --
 apps/keymaps/keymap-fuze.c        |    2 --
 25 files changed, 6 insertions(+), 66 deletions(-)

Comment by Frank Gevaerts (fg) - Tuesday, 23 December 2008, 21:11 GMT+2
This applies and builds for all 3.1 release targets. I tested it on some of them, and saw no problems
Comment by Thomas Martitz (kugel.) - Tuesday, 23 December 2008, 21:15 GMT+2
Thanks! Sounds promising :)

Loading...