Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#9662 - Sansa e200: Power (stop) button behaves inconsistent and weird.

Attached to Project: Rockbox
Opened by Thomas Martitz (kugel.) - Wednesday, 17 December 2008, 18:06 GMT+2
Last edited by Thomas Martitz (kugel.) - Sunday, 25 January 2009, 15:55 GMT+2
Task Type Bugs
Category User Interface
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Release 3.0
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

Pressing the power button in the database or filebrowser doesn't only stop the playback but also goes up one dir level. It should stop only.

But it gets worse: If you browse plugins through the main menu or browse themes/fonts/wps/config files through the respective settings menu, it does only go back to the settings menu, without stopping playback.

Revision: r19457
This task depends upon

Closed by  Thomas Martitz (kugel.)
Sunday, 25 January 2009, 15:55 GMT+2
Reason for closing:  Accepted
Additional comments about closing:  Committed in r19851, thanks
Comment by Thomas Martitz (kugel.) - Thursday, 18 December 2008, 14:16 GMT+2
Here's the fix. The problem was that in several screens STOP was still registered as cancel button. I made |<< be the cancel button in those.

Exception: Rec screen: Down is now cancel button too (as it goes to the main menu, the general down button function), and power stays as cancel, since it also means to stop the recording (and power should stop).
   stop-button-e200.patch (3 KiB) 
 apps/keymaps/keymap-e200.c |   10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)

Comment by Thomas Martitz (kugel.) - Sunday, 28 December 2008, 15:59 GMT+2
So, this should be the one to go with imo.
Please test, most noticeable changes are in the time screen.

Yes, langs need fixing before committing.
   stop-button-e200-v2.patch (6 KiB) 
 apps/keymaps/keymap-e200.c |   44 +++++++++++++++++++++-----------------------
 1 file changed, 21 insertions(+), 23 deletions(-)

Comment by Thomas Martitz (kugel.) - Wednesday, 21 January 2009, 23:17 GMT+2
I'm going to commit this until weekend if there's no issues or objections. Until then, I keep testing in every-day life.

Loading...