Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#9663 - Sansa e200v2/Fuze: "nearly" fix buttonlight, enable backlight sw fading

Attached to Project: Rockbox
Opened by Thomas Martitz (kugel.) - Thursday, 18 December 2008, 03:14 GMT+2
Last edited by MichaelGiacomelli (saratoga) - Sunday, 18 January 2009, 19:50 GMT+2
Task Type Patches
Category Battery/Charging
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Release 3.0
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

This patch enables backlight sw fading for both mentioned targets. Looks nice on the Fuze.

It's also supposed to fix buttonlight. It generally works, but it needs more work.
It's quite unreliable!
It generally works if you press a button shortly after the very first buttonlight flash while booting, and it starts working if you do filesystem access. There may be other conditions.
It generally doesn't work if you boot normally, until something mentioned above happens.

I just want to add: buttonlight ain't trivial from what I've seen. Simply setting the pin is broken as soon as you add a MicroSD, since the MicroSD is blocking the GPIOD port. You basically cannot change xpd_func_sel to GPIO as long as you're using the MicroSD. And the buttonlight doesn't keep on just by setting the pin if you change to xpd.

What I did is what I found in the disassembly. It sets the Rod control register. It seems to work a bit, even though I have no idea what it actually is.

Enough talk, here's the patch
   backlight-buttonlight-changes.diff (4 KiB) 
 firmware/export/config-fuze.h                            |    5 +
 firmware/export/config-e200v2.h                          |    5 +
 firmware/backlight.c                                     |    7 +-
 firmware/target/arm/as3525/backlight-e200v2-fuze.c       |   42 ++++++++++++---
 firmware/target/arm/as3525/sansa-fuze/backlight-target.h |    3 -
 5 files changed, 52 insertions(+), 10 deletions(-)

This task depends upon

Closed by  MichaelGiacomelli (saratoga)
Sunday, 18 January 2009, 19:50 GMT+2
Reason for closing:  Accepted
Additional comments about closing:  Accepted in r19791 and r10792.
Comment by Michael Chicoine (mc2739) - Thursday, 18 December 2008, 13:57 GMT+2
You forgot the backlight-target.h changes for e200v2
   e200v2-backlight-target.h.diff (0.5 KiB) 
 firmware/target/arm/as3525/sansa-e200v2/backlight-target.h |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comment by Thomas Martitz (kugel.) - Saturday, 17 January 2009, 00:14 GMT+2
Update for the buttonlight, works good. It turns off for a split second at inserting a microsd, but I don't think it's a major issue (I'd even say it's a nice visual feedback on inserting the card).
   fuze-buttonlight.diff (3.1 KiB) 
 firmware/export/as3525.h                            |    1 +
 firmware/target/arm/as3525/backlight-e200v2-fuze.c  |    4 ++--
 firmware/target/arm/as3525/sansa-fuze/button-fuze.c |    1 +
 firmware/target/arm/as3525/ata_sd_as3525.c          |   12 ++++++++++--
 4 files changed, 14 insertions(+), 4 deletions(-)

Comment by Thomas Martitz (kugel.) - Saturday, 17 January 2009, 00:51 GMT+2
Here's an update on backlight fading. The huge #if in backlight.c could actually reduced to HAVE_AS3514.
   e200v2-fuze-backlight-fading.diff (2.9 KiB) 
 firmware/export/config-fuze.h                      |   11 ++++++-----
 firmware/export/config-e200v2.h                    |   11 ++++++-----
 firmware/backlight.c                               |    6 +++---
 firmware/target/arm/as3525/backlight-e200v2-fuze.c |    7 +++----
 4 files changed, 18 insertions(+), 17 deletions(-)

Loading...