Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#9666 - Invert albumart when LCD Mode is set to inverse

Attached to Project: Rockbox
Opened by Jonas Häggqvist (rasher) - Thursday, 18 December 2008, 19:32 GMT+2
Last edited by Jonas Häggqvist (rasher) - Thursday, 19 March 2009, 20:13 GMT+2
Task Type Patches
Category Themes
Status Closed
Assigned To No-one
Player Type SW-codec
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

This patch inverses album art in the WPS when LCD Mode is set to inverse. This makes the album art come out as it originally is, which is probably reasonable to do.

The patch also no longer sets the drawmode when drawing albumart, since the drawmode doesn't affect non-mono bitmaps.

This enables the user to use the "LCD Mode" setting to change a light theme into a dark one, and vice versa, without it ruining album art in the WPS.

Currently only tested in e200 sim.
   albumart_inversefix.diff (0.7 KiB) 
 apps/recorder/albumart.c |    7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

This task depends upon

Closed by  Jonas Häggqvist (rasher)
Thursday, 19 March 2009, 20:13 GMT+2
Reason for closing:  Accepted
Additional comments about closing:  Committed in r20357.
Comment by Jonas Häggqvist (rasher) - Thursday, 18 December 2008, 19:50 GMT+2
Properly wrap the relevant code in #ifdef HAVE_LCD_INVERT
   albumart_inversefix-FS#9666-v2.diff (0.8 KiB) 
 apps/recorder/albumart.c |    9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

Loading...