Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#9679 - c200v2: prepare Rockbox for it

Attached to Project: Rockbox
Opened by Thomas Martitz (kugel.) - Friday, 19 December 2008, 18:08 GMT+2
Last edited by MichaelGiacomelli (saratoga) - Wednesday, 24 December 2008, 05:24 GMT+2
Task Type Patches
Category Build environment
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Release 3.0
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

This task aims to add the c200v2 as a build target. It seems suitable as we have a c200v2 owner and tester (and I think he also codes).

The first patch makes mkamsboot create patched firmwares. Well, at least if you have a valid bootloader file, which isn't possible yet. Please review that one as it's critical (linuxstb?).
   mkamsboot.vc.diff (6.2 KiB) 
 rbutil/mkamsboot/dualboot.S  |   15 ++++++++++++++-
 rbutil/mkamsboot/Makefile    |   13 ++++++++++---
 rbutil/mkamsboot/mkamsboot.c |   43 ++++++++++++++++++++++---------------------
 3 files changed, 46 insertions(+), 25 deletions(-)

This task depends upon

Closed by  MichaelGiacomelli (saratoga)
Wednesday, 24 December 2008, 05:24 GMT+2
Reason for closing:  Accepted
Additional comments about closing:  Accepted in r19574+r19575.
Comment by Thomas Martitz (kugel.) - Friday, 19 December 2008, 18:53 GMT+2
This patch the c200v2 to the target tree. It'll build a bootloader which you can pass to mkamsboot.

Note: Most is guess work, except for the button driver. Especially the memory size would be valuable to know for sure, I guessed 8MB for now.

Please review this also. Thanks.
   c200v2-target-tree.diff (31.1 KiB) 
 bootloader/sansa_as3525.c                                  |    4 
 tools/configure                                            |   28 
 tools/scramble.c                                           |    2 
 firmware/export/config-c200v2.h                            |  209 ++++++
 firmware/export/config.h                                   |    2 
 firmware/SOURCES                                           |   13 
 firmware/target/arm/as3525/sansa-c200v2/backlight-target.h |   32 
 firmware/target/arm/as3525/sansa-c200v2/backlight-c200v2.c |   71 ++
 firmware/target/arm/as3525/sansa-c200v2/button-target.h    |   55 +
 firmware/target/arm/as3525/sansa-c200v2/button-c200v2.c    |  103 +++
 firmware/target/arm/as3525/sansa-c200v2/lcd-c200v2.c       |  429 +++++++++++++
 firmware/target/arm/as3525/system-as3525.c                 |    2 
 firmware/target/arm/as3525/clock-target.h                  |    2 
 13 files changed, 949 insertions(+), 3 deletions(-)

Comment by Thomas Martitz (kugel.) - Friday, 19 December 2008, 19:00 GMT+2
Just a little disclaimer: Both patches are completely untested. They may or may not brick your player. Please do not apply if you can't live with a brick.
Comment by Thomas Martitz (kugel.) - Tuesday, 23 December 2008, 16:41 GMT+2
So, this one is tested and declared safe. I only changed the right button detection to trigger on C6 == low, not high. The other is readability (#ifdef SANSA_C200V2 instead of #ifndef ..).

I guess it can be committed
   mkamsboot.vc.diff (6.5 KiB) 
 rbutil/mkamsboot/dualboot.S  |   16 +++++++++++++++-
 rbutil/mkamsboot/Makefile    |   13 ++++++++++---
 rbutil/mkamsboot/mkamsboot.c |   43 ++++++++++++++++++++++---------------------
 3 files changed, 47 insertions(+), 25 deletions(-)

Comment by Thomas Martitz (kugel.) - Tuesday, 23 December 2008, 16:57 GMT+2
Ok, changed the target tree patch to reflect the new findings (more butons, 2MB RAM).

Given that RockRabbit successfully built a bootloader with both patches they can go it (if there's no objections regarding the more-dummy-than-working lcd-driver).
   c200v2-target-tree.diff (31.4 KiB) 
 bootloader/sansa_as3525.c                                  |    4 
 tools/configure                                            |   28 
 tools/scramble.c                                           |    2 
 firmware/export/config-c200v2.h                            |  209 ++++++
 firmware/export/config.h                                   |    2 
 firmware/SOURCES                                           |   13 
 firmware/target/arm/as3525/sansa-c200v2/backlight-target.h |   32 
 firmware/target/arm/as3525/sansa-c200v2/backlight-c200v2.c |   71 ++
 firmware/target/arm/as3525/sansa-c200v2/button-target.h    |   55 +
 firmware/target/arm/as3525/sansa-c200v2/button-c200v2.c    |  111 +++
 firmware/target/arm/as3525/sansa-c200v2/lcd-c200v2.c       |  429 +++++++++++++
 firmware/target/arm/as3525/system-as3525.c                 |    2 
 firmware/target/arm/as3525/clock-target.h                  |    2 
 13 files changed, 957 insertions(+), 3 deletions(-)

Loading...