Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#9689 - greylib pictureflow for greyscale targets

Attached to Project: Rockbox
Opened by Andrew Mahone (Unhelpful) - Sunday, 21 December 2008, 06:00 GMT+2
Last edited by Andrew Mahone (Unhelpful) - Saturday, 17 January 2009, 01:38 GMT+2
Task Type Patches
Category Plugins
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Release 3.0
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

This patch allows pictureflow to be used on greyscale (but not mono) targets using greylib, and the new greylib scaler. It requires the recent updates from  FS#9458 , and the scaler output plugging support and greylib output plugin from  FS#9683 . It incorporates my previous pictureflow scaling patch from  FS#9665 , which does not apply cleanly over the other two patches.

The tracklist and album view work exactly as on color targets, in greyscale. The greylib overlay is disabled in the config menu, as this does not rely on color. I have tested on Mini 2G and iPod 4G sims, as well as on iPod video sim (to verify color works correctly).
   pictureflow_greylib_200812202353.patch (33.7 KiB) 
 b/apps/plugins/SOURCES                     |    5 
 b/apps/plugins/bitmaps/native/SOURCES      |    7 
 b/apps/plugins/pictureflow.c               |  378 ++++++++++++++---------------
 b/apps/plugins/test_greylib_bitmap_scale.c |   78 +++++
 b/tools/buildzip.pl                        |    4 
 5 files changed, 272 insertions(+), 200 deletions(-)

Closed by  Andrew Mahone (Unhelpful)
Saturday, 17 January 2009, 01:38 GMT+2
Reason for closing:  Accepted
Additional comments about closing:  this work was committed in r19598
Comment by Andrew Mahone (Unhelpful) - Sunday, 21 December 2008, 18:09 GMT+2
Reordered loops while creating reflection, so that some math can be moved out of the inner loop. Also made the scaling factor used for the reflection a constant, and of lower precision, to replace a 32x32->64 multiply with a ->32 one.
   pictureflow_greylib_200812211205.patch (33.8 KiB) 
 b/apps/plugins/SOURCES                     |    5 
 b/apps/plugins/bitmaps/native/SOURCES      |    7 
 b/apps/plugins/pictureflow.c               |  385 ++++++++++++++---------------
 b/apps/plugins/test_greylib_bitmap_scale.c |   78 +++++
 b/tools/buildzip.pl                        |    4 
 5 files changed, 277 insertions(+), 202 deletions(-)

Loading...