Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#9695 - Rockbox Utility - German Translation

Attached to Project: Rockbox
Opened by Jens Erdmann (pyro_maniac) - Sunday, 21 December 2008, 22:24 GMT+2
Last edited by Dominik Riebeling (bluebrother) - Thursday, 08 January 2009, 17:30 GMT+2
Task Type Patches
Category Rbutil
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details


This patch completes the german translation for the qt version of the rockbox utility.

   german-translation.patch (7.8 KiB) 
 b/rbutil/rbutilqt/lang/rbutil_de.ts |   19 ++++++++++---------
 1 file changed, 10 insertions(+), 9 deletions(-)

This task depends upon

Closed by  Dominik Riebeling (bluebrother)
Thursday, 08 January 2009, 17:30 GMT+2
Reason for closing:  Rejected
Additional comments about closing:  see comments.
Comment by Dominik Riebeling (bluebrother) - Tuesday, 23 December 2008, 00:56 GMT+2
Can you please clarify what this patch does complete? As far as I can see it only marks translations as finished that have been left in the "unfinished" state (which I did intentionally). The translation will be used nevertheless (unless -nounfinished is used when calling lrelease, which isn't done).
Comment by Jens Erdmann (pyro_maniac) - Wednesday, 24 December 2008, 01:29 GMT+2
No there is no translation left. And i not only finished up the translations, i also made a change.
Comment by Johannes Linke (Jaykay) - Thursday, 25 December 2008, 20:11 GMT+2

- Aktuell installierte Pakete.&lt;br/&gt;&lt;b&gt;Hinweis:&lt;/b&gt; wenn Pakete manuell installiert wurden wird diese Anzeige nicht korrekt sein!</translation>
+ Aktuell installierte Pakete.&lt;br/&gt;&lt;b&gt;Hinweis:&lt;/b&gt; Wenn Pakete manuell installiert wurden, könnte diese Anzeige nicht korrekt sein!</translation>

biggest change ever. but why were the strings all marked with unfinished?

the patch adds <defaultcodec></defaultcodec>, i dont know whether this is useful....
Comment by Jens Erdmann (pyro_maniac) - Thursday, 25 December 2008, 21:56 GMT+2
I don't know if you used the tools of QT but this is the way it works. There is no "finish" tag for translations. Unmarked translations are set to finish and the defaultcodec tag was set by the qt4 linguist itself.
Comment by Johannes Linke (Jaykay) - Thursday, 25 December 2008, 22:42 GMT+2
the question was why they were tagged with "unfinished"....
Comment by Jens Erdmann (pyro_maniac) - Friday, 26 December 2008, 10:56 GMT+2
I am not shure but sometimes small changes on the string or in the code make the lupdate to tag this with "unfinished". I cant really say what happed.
Comment by Dominik Riebeling (bluebrother) - Wednesday, 07 January 2009, 11:36 GMT+2
Translations can get marked as finished or unfinished in linguist. In this case I intentionally left some translations with the status unfinished (stated above already) as I wasn't too happy with them and just used this as marking for myself to look over them again later.

Also, I disagree with the changed line -- if you install packages manually the info tab *will* be wrong, it's not that it *might* be. Unless someone explains me why this change should be made the next couple of days I'm going to reject this patch.
Comment by Jens Erdmann (pyro_maniac) - Wednesday, 07 January 2009, 11:56 GMT+2
Do you disagree with the translation or with a change on the original file?
Comment by Dominik Riebeling (bluebrother) - Wednesday, 07 January 2009, 14:43 GMT+2
I disagree with the translation.
Comment by Jens Erdmann (pyro_maniac) - Wednesday, 07 January 2009, 15:47 GMT+2
In my opinion it must be a "might" because there is no guarantee that that the informations are wrong for manual installations. Maybe this describes it best.
Comment by Johannes Linke (Jaykay) - Wednesday, 07 January 2009, 21:36 GMT+2
"if you install packages manually the info tab *will* be wrong, it's not that it *might* be. "

i think dominik wrote it quite clearly, didnt he? i suggest closing (of this task).
Comment by Jens Erdmann (pyro_maniac) - Wednesday, 07 January 2009, 23:56 GMT+2
Sorry i might had to read it twice to understand it. I was focused to much on the translation then on how it really is. So you might close it with the result that the translations are good as they are in my opinion.

Loading...