This is the bug/patch tracker for Rockbox. Click here for more information.
Quick links: Bugs · Patches · Rockbox frontpage
FS#9706 - Quickscreen: 4th item + some optimisations for remotes
Attached to Project:
Rockbox
Opened by Thomas Martitz (kugel.) - Wednesday, 24 December 2008, 05:07 GMT+2
Last edited by Thomas Martitz (kugel.) - Saturday, 29 August 2009, 16:43 GMT+2
Opened by Thomas Martitz (kugel.) - Wednesday, 24 December 2008, 05:07 GMT+2
Last edited by Thomas Martitz (kugel.) - Saturday, 29 August 2009, 16:43 GMT+2
|
DetailsSo, after the trouble with
It also tries to handle remotes, as it shows only three items (not the top one) on those, since the space and buttons are limited. So, it keeps ACTION_QS_DOWNINV for remotes and recorder. Basically those screens that have this can only show 3 items. It also rewrites the viewport preparation in the quickscreen a little bit (not too much), was a bit messy to get the 4th item properly working without. TODO: - Veryify that it works on remotes; I tried to test, it "looks" correct going by the sims, but those aren't very good to test buttons and such I noticed - Handle Recorder so that he doesn't show the 4th item Please test and leave some comments! 
4th-qs-item.diff
(34.5 KiB)
apps/action.h | 5 - apps/lang/deutsch.lang | 17 ++++ apps/lang/english.lang | 17 ++++ apps/gui/quickscreen.c | 151 ++++++++++++++++++++++++-------------- apps/gui/quickscreen.h | 3 apps/menu.c | 10 +- apps/settings.h | 1 apps/settings_list.c | 4 + apps/keymaps/keymap-m200.c | 4 - apps/keymaps/keymap-sa9200.c | 4 - apps/keymaps/keymap-m3.c | 4 - apps/keymaps/keymap-h1x0_h3x0.c | 4 - apps/keymaps/keymap-creativezv.c | 4 - apps/keymaps/keymap-touchscreen.c | 4 - apps/keymaps/keymap-ifp7xx.c | 4 - apps/keymaps/keymap-iaudio67.c | 4 - apps/keymaps/keymap-clip.c | 4 - apps/keymaps/keymap-h10.c | 4 - apps/keymaps/keymap-av300.c | 4 - apps/keymaps/keymap-x5.c | 4 - apps/keymaps/keymap-creativezvm.c | 4 - apps/keymaps/keymap-mr100.c | 4 - apps/keymaps/keymap-logikdax.c | 4 - apps/keymaps/keymap-gigabeat.c | 4 - apps/keymaps/keymap-gigabeat-s.c | 4 - apps/keymaps/keymap-c100.c | 4 - apps/keymaps/keymap-c200.c | 4 - apps/keymaps/keymap-e200.c | 4 - apps/keymaps/keymap-meizu-m6sl.c | 4 - apps/keymaps/keymap-hdd1630.c | 4 - apps/keymaps/keymap-fuze.c | 4 - 31 files changed, 195 insertions(+), 105 deletions(-) |
This task depends upon
Closed by Thomas Martitz (kugel.)
Saturday, 29 August 2009, 16:43 GMT+2
Reason for closing: Accepted
Additional comments about closing: Committed in r22531.
Saturday, 29 August 2009, 16:43 GMT+2
Reason for closing: Accepted
Additional comments about closing: Committed in r22531.
FS#9675) :(also added a mechanism to detect ACTION_QS_DOWN_INV in keymaps so that the top in favor of inverting the bottom one (needed for archos recorder and some remotes).
I completely disagree with the top item handling.... by all means change the action name to TOP but having TOP and DOWNINV makes no sense... the logic should be if there is room for the top item, and it is set, then use TOP to change it.. otherwise do the downinv handling (which should be the same for all 4 directions)...
also, using a default which is target dependant is a bad idea from a support POV...
"by all means change the action name to TOP but having TOP and DOWNINV makes no sense" I don't understand. TOP is added, and DOWNINV still exists. If targets use DOWNINV, they won't have a TOP (or can't use it).
As you've written yourself in
FS#9675, we can't just have TOP on all targets. This is the special handling you talked about.The default val is probably questionable, indeed.
exactly why there is no need for special handling... call it BUTTON_QS_UP if top doesnt work for you..
It can't be the same action since the action is searched for at detecting the special case (it searches for DOWNINV in the qs keymap array).
I optimized displaying so far that special handling of small screens shouldn't be needed (with 64px, even a 13-14px font works cool).