FS#9724 - Backlight fading: code police
Opened by Thomas Martitz (kugel.) - Monday, 29 December 2008, 02:22 GMT
Last edited by Thomas Martitz (kugel.) - Tuesday, 27 January 2009, 00:29 GMT
Here's some code police, suggested by Zagor, and going slightly farer.
-rename USE_BACKLIGHT_SW_FADING and USE_BACKLIGHT_CUSTOM_FADING_BOOL to HAVE_* to be more consistent with the other config #defines
-add a BACKLIGHT_ON_TYPE config, so that the #if <target> in backlight.c are not so target-specific
-reword/rewrite comments and add some to clear things up
Note1: should be tested on affected targets for safety (grep didn't show a missing rename), mainly on the BACKLIGHT_ON_HARDWARE targets (I tested on my BACKLIGHT_ON_SETTING e200)
Note2: I'd also like to have backlight-thread-fading.[c/h] renamed to backlight-sw-fading.[c/h], I didn't do that since svn diff doesn't do well with svn mv'd files, those should be renamed at committing or in a seperate commit
PS: I'd really like to fuse the backlight drivers for e200,c200,fuze,e200v2,sa9200 (probably c200v2), since I noticed that they're all entirely the same, except for buttonlight (that should be kept seperate). Opinions on that?
Tuesday, 27 January 2009, 00:29 GMT
Reason for closing: Accepted
Additional comments about closing: Committed in r19860, thanks.