Rockbox

Tasklist

FS#9747 - Last.fm log sets bogus tracknumber when not set in the tag

Attached to Project: Rockbox
Opened by Jonas Häggqvist (rasher) - Friday, 02 January 2009, 17:31 GMT
Last edited by Jonas Häggqvist (rasher) - Thursday, 08 January 2009, 22:28 GMT
Task Type Bugs
Category Music playback
Status Closed
Assigned To Robert Keevil (obo)
Operating System All players
Severity Low
Priority Normal
Reported Version Version 3.1
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

As the summary says, when the tag doesn't set a tracknumber, the scrobbler.log contains a weird value instead of simply leaving it out as the format specifies (http://www.audioscrobbler.net/wiki/Portable_Player_Logging): "# If the data for optional fields is not available to you, leave the field blank (\t\t)."
This task depends upon

Closed by  Jonas Häggqvist (rasher)
Thursday, 08 January 2009, 22:28 GMT
Reason for closing:  Invalid
Additional comments about closing:  I can't reproduce - maybe I was just looking at the wrong stuff. I'll keep an eye on it
Comment by Robert Keevil (obo) - Sunday, 04 January 2009, 15:02 GMT
I can't reproduce this - creating test tracks with no track number field just result in "\t\t" in the log. QTScrobbler didn't handle that though (it assumed there would be an int present), so I've commited a change there. What I did notice is that the RB scrobbler logging doesn't use track_string (string version of tracknum in the RB mp3entry struct), but I'm looking into changing that.

Loading...