Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#9763 - Sansa Clip modified WPS

Attached to Project: Rockbox
Opened by Bertrik Sikken (bertrik) - Monday, 05 January 2009, 20:58 GMT+2
Last edited by Bertrik Sikken (bertrik) - Saturday, 31 January 2009, 13:25 GMT+2
Task Type Patches
Category Themes
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Version 3.1
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

The Sansa Clip has a 128x64x1 display and currently re-uses the remote cabbiev2 WPS for Iriver players. A unique feature of the Clip display is that it is split up in two sections, an upper 128x16 yellow section, then two empty lines and a lower 128x48 cyan section. This results in the problem that the title/artist/album info in the current cabbiev2 WPS gets split up between the yellow and the cyan part, making it look ugly and harder to read.

This patch gives some suggestions for an alternative cabbiev2 128x64x1 WPS, more suitable for the Sansa Clip screen.

Screenshot clip_wps_org.png shows how the WPS currently looks on the Clip.
Patch wps_clip.patch moves the "X of Y" and "MM:SS" progress text up in the yellow part, such that the title/artist/album info is no longer split, see screenshot clip_wps.png
Patch wps_clip2.patch simply moves the title/artist/album a little lower, see screenshot clip_wps2.png.
   clip_wps.png (3.8 KiB)
   clip_wps2.png (3.8 KiB)
   clip_wps_org.png (3.8 KiB)
   wps_clip.patch (1.4 KiB) 
 wps/cabbiev2.128x64x1.wps |   30 +++++++++++++++---------------
 1 file changed, 15 insertions(+), 15 deletions(-)

   wps_clip2.patch (0.8 KiB) 
 wps/cabbiev2.128x64x1.wps |    8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

This task depends upon

Closed by  Bertrik Sikken (bertrik)
Saturday, 31 January 2009, 13:25 GMT+2
Reason for closing:  Accepted
Additional comments about closing:  Committed with minor fixes as svn r19889
Comment by Rafaël Carré (funman) - Thursday, 08 January 2009, 08:18 GMT+2
I like a lot the first patch !!

I discussed with pixelma and she said that these diffs must be specific to the Clip, and not applied to other 128x64x1 screens (because they use a font size 9 by default for example).

I believe a simple patch to wpsbuild.pl could look for a cabbiev2-resolution-model.wps before cabbiev2-resolution.wps
Comment by Thomas Martitz (kugel.) - Thursday, 22 January 2009, 20:45 GMT+2
How's that one? I like that slightly more.

Just to say what's different between your first and my one:
the bar is 1-2 pixel more up, the tag ingo 1-2 pixel more down, which makes the tag info a bit more centered (and eye-friendly ;) )
   clip-cabbie-3.png (84.8 KiB)
   cabbiev2.wps (0.9 KiB)
Comment by Bertrik Sikken (bertrik) - Wednesday, 28 January 2009, 22:46 GMT+2
Attached patch updates the root.make, buildzip.pl and wpsbuild.pl scripts to preferentially select theme.resolution.modelname.wps over theme.resolution.wps (for example cabbiev2.128x64x1.clip.wps is chosen instead of cabbiev2.128x64x1.wps). Also included is the cabbiev2.wps suggested by kugel, with a fix to the "now playing" text (shifted 1 pixel down).
   wps_clip3.patch (6.5 KiB) 
 tools/buildzip.pl              |    6 +++---
 tools/root.make                |   14 +++++++-------
 wps/cabbiev2.128x64x1.clip.wps |   34 ++++++++++++++++++++++++++++++++++
 wps/wpsbuild.pl                |    6 ++++++
 4 files changed, 50 insertions(+), 10 deletions(-)

Loading...