Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#9772 - Statusbar shown in WPS even though %wd tag is used.

Attached to Project: Rockbox
Opened by PaulJam (PaulJam) - Thursday, 08 January 2009, 22:54 GMT+2
Last edited by Jonathan Gordon (jdgordon) - Saturday, 10 January 2009, 14:16 GMT+2
Task Type Bugs
Category Themes
Status Closed
Assigned To Jonathan Gordon (jdgordon)
Player Type Another
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

On targets with LCD remote the statusbar is shown on both WPS when it is spposed to only show in either the remote WPS or the main WPS.

Reproduction:
Choose a WPS which does not show the statusbar (for example Cabbiev2), and then select a remote WPS that displays the statusbar (for example rockbox_default). Now the statusbar is shown in the main WPS too.

H300 (uisimulator) with r19728.
This task depends upon

Closed by  Jonathan Gordon (jdgordon)
Saturday, 10 January 2009, 14:16 GMT+2
Reason for closing:  Fixed
Additional comments about closing:  fixed in 19742.
Comment by Dominik Riebeling (bluebrother) - Friday, 09 January 2009, 00:37 GMT+2
this does not only affect the remote but also various themes -- Rockboxed and zezayer (on h100 sim) show the statusbar flickering on top of the wps instead of hiding it.
Comment by Jonathan Gordon (jdgordon) - Friday, 09 January 2009, 07:00 GMT+2
ah bugger... yeah, oversight on my part... Need to figure out a clean way of fixing this... for the time being, dont use a theme which only has it enabled on one screen... ill fix this over the weekend
Comment by Jonathan Gordon (jdgordon) - Saturday, 10 January 2009, 12:50 GMT+2
quick testing shows this to work... but proper testing might be useful :p
   wpsfix.diff (1.1 KiB) 
 apps/gui/gwps-common.c |   12 ++++++++++++
 apps/gui/gwps.c        |    1 +
 2 files changed, 13 insertions(+)

Comment by Dominik Riebeling (bluebrother) - Saturday, 10 January 2009, 13:11 GMT+2
checked on h120, looks good.

Loading...