Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#9857 - Patch for switching off the buttonlight while the Select-Button is pressed: nice visual feedback

Attached to Project: Rockbox
Opened by Martin Brocksch (fruchtschwert) - Sunday, 01 February 2009, 19:27 GMT+2
Last edited by Dominik Riebeling (bluebrother) - Sunday, 05 June 2011, 11:37 GMT+2
Task Type Patches
Category Drivers
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Version 3.1
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

This patch is part of a new feature request.
I tried it out with my Sansa e200 which has an illuminated scrollring.

Now my proposal:

When the user is pressing the Select-Button (for example to choose an entry from the menu) the button-driver should turn off the light of the scrollring as long as the button is pressed.
It then appears as if the buttonlight is kind of "flashing" for a moment.

This is a nice visual feedback for pressing the button.

Attached you can find the patch for Rockbox 3.1, which I implemented for my Sansa e200.
The only file which is changed is "firmware/drivers/button.c".
The code should work for all players (of course only makes sense if a buttonlight is available).
This task depends upon

Closed by  Dominik Riebeling (bluebrother)
Sunday, 05 June 2011, 11:37 GMT+2
Reason for closing:  Out of Date
Additional comments about closing:  no interest in the last 2 years, out of date.
Comment by Martin Brocksch (fruchtschwert) - Sunday, 01 February 2009, 19:29 GMT+2
here is the patch file ..
   buttonlight.patch (0.7 KiB) 
 rockbox-3.1-buttonlight/firmware/drivers/button.c |    7 +++++++
 1 file changed, 7 insertions(+)

Comment by Martin Brocksch (fruchtschwert) - Sunday, 01 February 2009, 19:43 GMT+2
You can find the forum discussion here:

http://forums.rockbox.org/index.php?topic=20441.0
Comment by John Gu (einmus) - Thursday, 05 February 2009, 03:22 GMT+2
I applied your patch, and I think it's great. But here's the thing:

When you make button backlight off, your patch isn't gonna work!

Loading...