Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#9879 - Quit the lamp plugin by pressing a dedicated QUIT button

Attached to Project: Rockbox
Opened by Alexander Levin (fml2) - Saturday, 07 February 2009, 22:19 GMT+2
Task Type Patches
Category Plugins
Status Unconfirmed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Version 3.1
Due in Version Undecided
Due Date Undecided
Percent Complete 0%
Private No

Details

As of r19940, the lamp plugin is quit by pressing any key besides some which have a function in that plugin (or so is the intention --see bug report  FS#9877 ).

This patch changes the plugin so that it's left with a special button only. The patch also adds key definitions for some players that haven't been included before (players without color LCD). Key mappings were taken from the patch in FS#8934.

Essentially, this patch implements an atomic part of that patch.

Also, correct handling of USB has been added.

This is in preparation of a (separate) patch for toggling the light on and off without leaving the plugin.
   lamp_quit_with_stop.patch (5.7 KiB) 
 apps/plugins/lamp.c |   88 +++++++++++++++++++++++++++++++++++++++-------------
 1 file changed, 67 insertions(+), 21 deletions(-)

This task depends upon

Comment by Thomas Martitz (kugel.) - Monday, 09 February 2009, 20:08 GMT+2
It's a feature that any button any button exits it! Why change that?
Comment by Alexander Levin (fml2) - Monday, 09 February 2009, 21:01 GMT+2
Not any button exits. Some buttons have other funcs (switching color only -- now). If we introduce the feature ON/OFF then, I think, the exit button should be defined explicitly and not as "any button not assigned a function."
Comment by Thomas Martitz (kugel.) - Monday, 09 February 2009, 21:01 GMT+2
Not in my opinion. I like that any button exits it (yes, except for the ones that change the color..)

Loading...