Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#9893 - Text viewer plugin: Patch that saves preference at each file

Attached to Project: Rockbox
Opened by Yoshihisa Uchida (Uchida) - Wednesday, 11 February 2009, 08:56 GMT+2
Last edited by Yoshihisa Uchida (Uchida) - Wednesday, 17 March 2010, 13:23 GMT+2
Task Type Patches
Category Plugins
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

The display setting is saved at each text file.

The configuration file name was changed.
viewer_bookmark.dat -> viewer_file.dat
   viewer_settings.patch (17.9 KiB) 
 b/apps/plugins/viewer.c |  416 +++++++++++++++++++++++++++---------------------
 1 file changed, 239 insertions(+), 177 deletions(-)

This task depends upon

Closed by  Yoshihisa Uchida (Uchida)
Wednesday, 17 March 2010, 13:23 GMT+2
Reason for closing:  Accepted
Additional comments about closing:  patch commits and manual updates.
Comment by Yoshihisa Uchida (Uchida) - Thursday, 12 February 2009, 11:31 GMT+2
Patch updates.

changes:
- Bug: Ｉｆ scroll mode = PAGE, when text scroll up, the page number decrements 2.
   viewer_settings_2.patch (18.3 KiB) 
 b/apps/plugins/viewer.c |  421 +++++++++++++++++++++++++++---------------------
 1 file changed, 242 insertions(+), 179 deletions(-)

Comment by Yoshihisa Uchida (Uchida) - Thursday, 12 February 2009, 11:34 GMT+2
Additional comment.

Please apply patchs in order of  FS#9855 , #9892, and #9893.
Comment by Yoshihisa Uchida (Uchida) - Thursday, 05 March 2009, 14:20 GMT+2
This patch file updates.

Changes:
- It is corrected that initialization is not read from the "viewer.dat" file.
   viewer_settings_3.patch (17.7 KiB) 
 b/apps/plugins/viewer.c |  389 ++++++++++++++++++++++++++----------------------
 1 file changed, 217 insertions(+), 172 deletions(-)

Comment by Tri Nguyen (tri170391) - Thursday, 05 March 2009, 14:29 GMT+2
Is thete any way to have "global" settings with this patch. Right now if I want to disable File Name, Page Number I have to do it with each files. It's rather annoying IMO ...
Comment by Yoshihisa Uchida (Uchida) - Friday, 06 March 2009, 13:58 GMT+2
Thank you for the comment.

I create the patch file that can set global settings.
Please see  FS#9900 .

When the text file that settings are not saved in ".rocks/viewer/viewer_file.dat" is read, global settings (in "viewer.dat") are used.
Comment by Yoshihisa Uchida (Uchida) - Saturday, 07 March 2009, 03:46 GMT+2
Sorry  FS#9900  ->  FS#9990 
Comment by Yoshihisa Uchida (Uchida) - Wednesday, 17 June 2009, 11:09 GMT+2
svnc r21316
   viewer_settings_4.patch (17.7 KiB) 
 b/apps/plugins/viewer.c |  389 ++++++++++++++++++++++++++----------------------
 1 file changed, 217 insertions(+), 172 deletions(-)

Comment by Yoshihisa Uchida (Uchida) - Saturday, 20 February 2010, 03:47 GMT+2
sync r24782
   viewer_settings_5.patch (17.8 KiB) 
 b/apps/plugins/viewer.c |  391 ++++++++++++++++++++++++++----------------------
 1 file changed, 218 insertions(+), 173 deletions(-)

Loading...