Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#9899 - Text viewer plugin: unified patch

Attached to Project: Rockbox
Opened by Yoshihisa Uchida (Uchida) - Thursday, 12 February 2009, 11:51 GMT+2
Last edited by Paul Louden (Llorean) - Thursday, 12 February 2009, 20:43 GMT+2
Task Type Patches
Category Plugins
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

I have offered patch files to the following tasks:

 FS#8445  Text viewer crashes when jumping to end of file
 FS#9387  - display error for Asian text
 FS#9546  - UTF-8 BOM "visible" in viewer
 FS#9853  - Text viewer plugin is not displayed to the last line for the large size text file.
 FS#9855  - Text viewer plugin: Title and page number are displayed
 FS#9892  - Text viewer plugin: Patch by which user can set bookmarks freely.
 FS#9893  - Text viewer plugin: Patch that saves preference at each file.
 FS#9898  - Text viewer plugin: Font selection patch

It is a patch file that brings these patches together in one.


   viewer_unified.patch (60.6 KiB) 
 b/apps/plugins/viewer.c | 1433 ++++++++++++++++++++++++++++++++++++++++--------
 1 file changed, 1209 insertions(+), 224 deletions(-)

This task depends upon

Closed by  Paul Louden (Llorean)
Thursday, 12 February 2009, 20:43 GMT+2
Reason for closing:  Duplicate
Additional comments about closing:  Please keep patches small and to one task each.
Comment by Steve Bavin (pondlife) - Thursday, 12 February 2009, 16:16 GMT+2
Hi,

I would think that seperate, smaller patches are more likely to be used than big ones. I know it's more work to sync them, but think you should should do that and close this.
Comment by Tri Nguyen (tri170391) - Thursday, 12 February 2009, 16:56 GMT+2
This patch apply fine. But when compile it give a undefined reference to strcmp when linking. Built with vanilla SVN + this patch.

Loading...