Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#9933 - Sansa Fuze & e200v2: Unify drivers

Attached to Project: Rockbox
Opened by Thomas Martitz (kugel.) - Friday, 20 February 2009, 19:14 GMT+2
Last edited by Rafaël Carré (funman) - Saturday, 06 March 2010, 00:55 GMT+2
Task Type Patches
Category Operating System/Drivers
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Version 3.1
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

This patch unifies much of the now duplicated code for e200v2 and fuze in several new files (dbop-e200v2-fuze.c, lcd-e200v2-fuze.c, button-e200v2-fuze.c).

As far as my experience goes, this two targets have too much in common to have the code split and duplicated.

Needs testing on the e200v2. Also, I'm wondering if this good at all, since the other ams sansas are still split, and most functions cannot be static anymore.
   rockbox-fuze-svn.vc.diff (56.1 KiB) 
 firmware/SOURCES                                        |   10 
 firmware/target/arm/as3525/sansa-e200v2/lcd-e200v2.c    |  252 ++-----------
 firmware/target/arm/as3525/sansa-e200v2/button-target.h |    3 
 firmware/target/arm/as3525/sansa-e200v2/button-e200v2.c |  287 ---------------
 firmware/target/arm/as3525/system-as3525.c              |    1 
 firmware/target/arm/as3525/debug-as3525.c               |   11 
 firmware/target/arm/as3525/dbop-target.h                |   40 ++
 firmware/target/arm/as3525/button-e200v2-fuze.c         |  211 +++++++++++
 firmware/target/arm/as3525/dbop-e200v2-fuze.c           |  149 +++++++
 firmware/target/arm/as3525/lcd-e200v2-fuze.c            |  136 +++++++
 firmware/target/arm/as3525/sansa-fuze/button-fuze.c     |  258 -------------
 firmware/target/arm/as3525/sansa-fuze/button-target.h   |    3 
 firmware/target/arm/as3525/sansa-fuze/lcd-fuze.c        |  304 +++-------------
 13 files changed, 665 insertions(+), 1000 deletions(-)

This task depends upon

Closed by  Rafaël Carré (funman)
Saturday, 06 March 2010, 00:55 GMT+2
Reason for closing:  Out of Date
Comment by Thomas Martitz (kugel.) - Friday, 20 February 2009, 20:06 GMT+2
Ok, this one is properly diff'd against r20067
   rockbox-fuze-svn.vc.diff (56.1 KiB) 
 firmware/SOURCES                                        |   10 
 firmware/target/arm/as3525/sansa-e200v2/lcd-e200v2.c    |  252 ++-----------
 firmware/target/arm/as3525/sansa-e200v2/button-target.h |    3 
 firmware/target/arm/as3525/sansa-e200v2/button-e200v2.c |  287 ---------------
 firmware/target/arm/as3525/system-as3525.c              |    1 
 firmware/target/arm/as3525/debug-as3525.c               |   11 
 firmware/target/arm/as3525/dbop-target.h                |   40 ++
 firmware/target/arm/as3525/button-e200v2-fuze.c         |  211 +++++++++++
 firmware/target/arm/as3525/dbop-e200v2-fuze.c           |  149 +++++++
 firmware/target/arm/as3525/lcd-e200v2-fuze.c            |  136 +++++++
 firmware/target/arm/as3525/sansa-fuze/button-fuze.c     |  258 -------------
 firmware/target/arm/as3525/sansa-fuze/button-target.h   |    3 
 firmware/target/arm/as3525/sansa-fuze/lcd-fuze.c        |  304 +++-------------
 13 files changed, 665 insertions(+), 1000 deletions(-)

Comment by Jack Halpin (FlynDice) - Saturday, 21 February 2009, 06:58 GMT+2
Well it functions on my e280 but not well. The buttons work fine. The scrolling action is a step backward but we've had this discussion before. Scrolling does work as long as you turn the wheel rather slowly. If you turn the wheel quickly it starts to skip and even goes backwards at times. It also "wraps" the menus instead of stopping at the top and bottom. I understand that it works well on the fuze but I really think the e200v1 scroll code works better for the e200v2, especially after using it for the past week.... I couldn't get music playing no matter how hard I tried. Radio was not a problem though and plugins with the scrollwheel were similar to the menu action.
Comment by Thomas Martitz (kugel.) - Saturday, 21 February 2009, 14:18 GMT+2
Can you please try if changing "QUEUE_SKIP_COUNTER" in firmware/target/arm/as3525/sansa-e200v2/button-target.h to other values helps?
Comment by Jack Halpin (FlynDice) - Sunday, 22 February 2009, 00:41 GMT+2
I tried 0,1,2,4,6 and they all displayed pretty much the same behavior just the smaller numbers moved things quicker which I thought was to be expected. Playing music was not a problem but keeping it playing is not as consistent. The music not playing part of my previous comment was not related to this patch it seems, something else was wrong. The hold button behavior is back to normal with this patch also.
Comment by Thomas Martitz (kugel.) - Friday, 27 February 2009, 03:21 GMT+2
Ok, another approach. I base this on this one on the e200v2 scrollwheel driver. It doesn't contain much changes. I just implemented the repeat from the Fuze (repeat is particulary needed, so that it doesn't wrap on the end at lists, the fuze has it and it works there). I also implemented a preliminary acceleration, as to turn on wheel fast mode, if repeat is high enough.

I really want to unify the driver, and I hope going from the e200v2 side, it could work.
   rockbox-fuze-svn.vc.diff (69 KiB) 
 apps/keymaps/keymap-fuze.c                              |   79 ++--
 firmware/SOURCES                                        |   10 
 firmware/target/arm/as3525/sansa-e200v2/lcd-e200v2.c    |  252 ++-----------
 firmware/target/arm/as3525/sansa-e200v2/button-target.h |    3 
 firmware/target/arm/as3525/sansa-e200v2/button-e200v2.c |  287 ---------------
 firmware/target/arm/as3525/system-as3525.c              |    1 
 firmware/target/arm/as3525/debug-as3525.c               |   11 
 firmware/target/arm/as3525/dbop-target.h                |   40 ++
 firmware/target/arm/as3525/button-e200v2-fuze.c         |  275 ++++++++++++++
 firmware/target/arm/as3525/dbop-e200v2-fuze.c           |  149 +++++++
 firmware/target/arm/as3525/lcd-e200v2-fuze.c            |  136 +++++++
 firmware/target/arm/as3525/sansa-fuze/button-fuze.c     |  258 -------------
 firmware/target/arm/as3525/sansa-fuze/button-target.h   |    3 
 firmware/target/arm/as3525/sansa-fuze/lcd-fuze.c        |  304 +++-------------
 14 files changed, 770 insertions(+), 1038 deletions(-)

Comment by Jack Halpin (FlynDice) - Friday, 27 February 2009, 05:03 GMT+2
The menus still wrap but aside from that I would call the scroll action acceptable. No reversal or stall at high spin rates, not really jumpy. The wrap is a bit annoying though once you get used to no wrap. I tried to relate another patch to this one with the dbop delay removed and the gpio delay reduced to 2 from 50 but I couldn't figure out how. I think this patch you're working on would be the real target for that though.
Comment by Thomas Martitz (kugel.) - Friday, 27 February 2009, 15:34 GMT+2
I don't understand how the wrapping is not working for you. It should only wrap, if you slightly touch the wheel, when you are already at the end of the list.

You probably understood the code: If you repeatedly turn the wheel, say every tick task, then BUTTON_REPEAT is generated. And when BUTTON_REPEAT is true, then you don't wrap, else you wrap.

But in my code, it is just *highly unlikely to not have BUTTON_REPEAT*, since already two tick tasks in a row with scroll action will have the repeat.

So I ask you again, just to make sure: Does it always wrap or only if you're turning it slowly towards end of the list?
Comment by Jack Halpin (FlynDice) - Friday, 27 February 2009, 21:02 GMT+2
It wraps most of the time. It occasionally hesitates.
Comment by Thomas Martitz (kugel.) - Saturday, 28 February 2009, 18:57 GMT+2
It throws me off that this is working so differently on the e200v2 and fuze. My approach of generating BUTTON_REPEAT should be very generic (it generates it if there was wheel action in two consecutive tick tasks).

Another question, am I correct that the current e200v2 driver (in svn) does *never* wrap? If yes, that would certainly wrong, as other targets don't do that.
Comment by Jack Halpin (FlynDice) - Saturday, 28 February 2009, 22:43 GMT+2
That is correct as far as my e280v2 goes. With the current svn driver there is no way I can make the menu wrap. I've tried scrolling fast and slow. I've tried stopping at the end and then starting again, quickly, slowly and any other way I possibly could. I cannot get it to wrap at all. Remember, there is some kind of difference with the wheels on the e200's and fuze as you had good scrollwheel action on the fuze even before the red pixel workaround.
Comment by Thomas Martitz (kugel.) - Sunday, 01 March 2009, 15:54 GMT+2
That'd be super annoying if you ask me.
Comment by Shredded Wheat (Cougar4free) - Sunday, 17 January 2010, 23:53 GMT+2
I have an unusal problem that you may be able to help me with. Maybe not, but its worth a try. I have a Sansa Fuze 4GB that is perfectly normal, except for some bizarre reason the screen doesn't work. Everything else is factory-standard. And my music is already on it of course. I remember all the interfaces to the point that I can find any song myself, but I am planning on giving it to a friend and would like to install voice commands, which Rockbox is said to have. Pretend she's blind. The normal install can't find the device, and for some reason the zip file for manual installation doesn't appear on the list (http://www.rockbox.org/download/byhand.cgi). If there is a solution, please email me at cashjohnsen@hotmail.com, and thank you.

Loading...