FS#9953 : Add Playback Control to more plugins

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

FS#9953 - Add Playback Control to more plugins

Attached to Project: Rockbox
Opened by Joshua Simmons (mud) - Wednesday, 25 February 2009, 19:10 GMT+2

Task Type	Patches
Category	Plugins
Status	Unconfirmed
Assigned To	No-one
Player Type	All players
Severity	Low
Priority	Normal
Reported Version	Daily build (which?)
Due in Version	Undecided
Due Date	Undecided
Percent Complete
Private	No

Details

I've noticed that many plugins don't have the Playback Control menu even though they could. I'm going to have a go at fixing that.

I've categorised the plugins which could use the menu like so:

Already have a standard-ish menu (not bitmap), it just needs to be added:
bubbles
chessbox
chopper
minesweeper
reversi
superdom
wormlet
xobox
clock
fireworks
vu_meter

These are the easiest case, it's just a matter of adding the menu item.

Don't have a menu that makes sense to add Playback Control to (either they don't have a menu at all, or they only have a start-menu that can't be usefully returned to):
flipit
invadrox
maze
robotfindskitten
rockblox
rockblox1d
rocklife
sliding_puzzle
snake
snake2
spacerocks
star
stopwatch
mandelbrot
oscilloscope

These are a mixed bunch. Some could actually use a menu, and some could just have a key assigned to bring up the Playback Control menu. More involved than the first bunch in general.

Already have a menu, but it's really custom in some way. They either need to be switched to more standard menus, or something special needs to be done:
brickmania
chessclock
pegbox
rockpaint

These will probably be the most work.

Let me know if I forgot any plugins, or if you think it doesn't make sense to add the menu to a plugin that I've listed above.

Attached is a patch for the first bunch. The others will be coming eventually.

I'd appreciate it if you leave this FS entry open until I get to the second and third bunch, even if the first bunch happens to get commited to svn.

group1.patch (11.1 KiB)

 b/apps/plugins/bubbles.c             |    9 +++++++--
 b/apps/plugins/chessbox/chessbox.c   |    7 ++++++-
 b/apps/plugins/chopper.c             |    6 +++++-
 b/apps/plugins/clock/clock_menu.c    |    8 +++++++-
 b/apps/plugins/fireworks.c           |    6 ++++++
 b/apps/plugins/minesweeper.c         |    8 +++++++-
 b/apps/plugins/reversi/reversi-gui.c |    8 +++++++-
 b/apps/plugins/superdom.c            |    6 +++++-
 b/apps/plugins/vu_meter.c            |    8 +++++++-
 b/apps/plugins/wormlet.c             |    6 +++++-
 b/apps/plugins/xobox.c               |    5 ++++-
 11 files changed, 66 insertions(+), 11 deletions(-)

This task depends upon

Comments (14)
Related Tasks (0/0)

Comment by Joshua Simmons (mud) - Thursday, 26 February 2009, 08:42 GMT+2

Added playback control to brickmania. Depends on ~~FS#9956~~ (change brickmania to use a standard menu).

brickmania.patch (1.1 KiB)

 b/apps/plugins/brickmania.c |    7 +++++++
 1 file changed, 7 insertions(+)

Comment by Thomas Martitz (kugel.) - Thursday, 26 February 2009, 17:55 GMT+2

I'd appreciate if you don't open a task for each plugin.

The topic of this task is pretty generic, so if you choose good filenames for the patches, everything can be here.

Comment by Thomas Martitz (kugel.) - Thursday, 26 February 2009, 18:11 GMT+2

I just committed the first patch. Thank you very much.
I'll leave this open as you wanted.

Comment by Joshua Simmons (mud) - Thursday, 26 February 2009, 18:32 GMT+2

linuxstb pointed out that chessbox is an overlay on archos targets. It shouldn't have the menu in that case, so here's a patch to remove it on archos targets.

fix-chessbox-playback.patch (1.4 KiB)

 b/apps/plugins/chessbox/chessbox.c |   14 +++++++++++++-
 1 file changed, 13 insertions(+), 1 deletion(-)

Comment by Joshua Simmons (mud) - Thursday, 26 February 2009, 18:42 GMT+2

Sorry, attached wrong patch. Here it is again.

fix-chessbox-playback2.patch (1.4 KiB)

 b/apps/plugins/chessbox/chessbox.c |   14 +++++++++++++-
 1 file changed, 13 insertions(+), 1 deletion(-)

Comment by Joshua Simmons (mud) - Thursday, 26 February 2009, 23:10 GMT+2

Here's pegbox.

pegbox-menu.patch converts pegbox to use a standard menu. In addition to this patch, delete apps/plugins/bitmaps/native/pegbox_menu* .

pegbox-playback.patch goes _on top of_ pegbox-menu.patch and adds the playback_control menu.

kugel: Thanks for commiting that first bunch. I'll try to keep the patches all in here like you requested.

pegbox-menu.patch (14 KiB)

 b/apps/plugins/bitmaps/native/SOURCES |   22 --
 b/apps/plugins/pegbox.c               |  279 +++++++---------------------------
 2 files changed, 63 insertions(+), 238 deletions(-)

pegbox-playback.patch (1.1 KiB)

 b/apps/plugins/pegbox.c |    8 ++++++++
 1 file changed, 8 insertions(+)

Comment by Joshua Simmons (mud) - Friday, 27 February 2009, 01:21 GMT+2

chessclock was way easier than I thought it would be.

chessclock-playback.patch (1.2 KiB)

 b/apps/plugins/chessclock.c |    9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

Comment by Joshua Simmons (mud) - Friday, 27 February 2009, 02:39 GMT+2

rockpaint turned out easy as well.

rockpaint-playback.patch (1.6 KiB)

 b/apps/plugins/rockpaint.c |   11 +++++++++--
 1 file changed, 9 insertions(+), 2 deletions(-)

Comment by Joshua Simmons (mud) - Saturday, 28 February 2009, 00:48 GMT+2

I finished group 2 and I believe I'm done now. Attached are two patches, playback_control_or_quit.patch adds a function of that name to lib/playback_control.h, and is used in group2.patch. group2.patch adds the Playback Control menu in some fashion to the following plugins:
flipit, maze, oscilliscope, robotfindskitten, rockblox, rockblox1d, rocklife, sliding_puzzle, snake, snake2, spacerocks, star, stopwatch

Most of them now have a short menu upon "exiting" which lets the user choose Playback Control, Resume, or Quit. The plugins that had a pause mode, I changed the pause mode into a menu which allows them to select Playback Control, Resume or Quit. It's less consistent this way, but highjacking pause mode like that is superior to preventing immediate exit from plugins.

In summary, to get all of my changes that aren't in svn (as of r20133), the following patches should be applied roughly in order:
~~FS#9956~~
Delete apps/plugins/bitmaps/native/brickmania_menu*
brickmania.patch
pegbox-menu.patch
Delete apps/plugins/bitmaps/native/pegbox_menu*
pegbox-playback.patch
chessclock-playback.patch
rockpaint-playback.patch
playback_control_or_quit.patch
group2.patch

If you want all of the changes, all_changes.patch includes everything listed there. (you still need to delete the bitmaps manually, the patch can't do that)

If all of these patches get resolved in one way or another (accepted or rejected), this FS entry can now be closed.

playback_control_or_quit.patch (2.2 KiB)

 b/apps/plugins/lib/playback_control.c |   39 ++++++++++++++++++++++++++++++++++
 b/apps/plugins/lib/playback_control.h |   13 +++++++++++
 2 files changed, 52 insertions(+)

group2.patch (25.2 KiB)

 b/apps/plugins/flipit.c           |   36 +++++++++++-
 b/apps/plugins/maze.c             |   18 ++++++
 b/apps/plugins/oscilloscope.c     |   20 ++++++-
 b/apps/plugins/robotfindskitten.c |   20 ++++++-
 b/apps/plugins/rockblox.c         |   41 +++++++++++---
 b/apps/plugins/rockblox1d.c       |  106 ++++++++++++++++++++++----------------
 b/apps/plugins/rocklife.c         |   23 +++++---
 b/apps/plugins/sliding_puzzle.c   |   17 +++++-
 b/apps/plugins/snake.c            |   47 +++++++++-------
 b/apps/plugins/snake2.c           |   55 ++++++++++---------
 b/apps/plugins/spacerocks.c       |   54 +++++++++++++++++--
 b/apps/plugins/star.c             |   73 +++++++++++++++++++-------
 b/apps/plugins/stopwatch.c        |   17 +++++-
 13 files changed, 384 insertions(+), 143 deletions(-)

all_changes.patch (64.7 KiB)

 b/apps/plugins/bitmaps/native/SOURCES |   40 ---
 b/apps/plugins/brickmania.c           |  366 ++++++----------------------------
 b/apps/plugins/chessclock.c           |    9 
 b/apps/plugins/flipit.c               |   36 ++-
 b/apps/plugins/lib/playback_control.c |   39 +++
 b/apps/plugins/lib/playback_control.h |   13 +
 b/apps/plugins/maze.c                 |   18 +
 b/apps/plugins/oscilloscope.c         |   20 +
 b/apps/plugins/pegbox.c               |  283 ++++++--------------------
 b/apps/plugins/robotfindskitten.c     |   20 +
 b/apps/plugins/rockblox.c             |   41 ++-
 b/apps/plugins/rockblox1d.c           |  106 +++++----
 b/apps/plugins/rocklife.c             |   23 +-
 b/apps/plugins/rockpaint.c            |   11 -
 b/apps/plugins/sliding_puzzle.c       |   17 +
 b/apps/plugins/snake.c                |   47 ++--
 b/apps/plugins/snake2.c               |   55 ++---
 b/apps/plugins/spacerocks.c           |   54 ++++-
 b/apps/plugins/star.c                 |   73 +++++-
 b/apps/plugins/stopwatch.c            |   17 +
 20 files changed, 596 insertions(+), 692 deletions(-)

Comment by Johannes Schwarz (Ubuntuxer) - Sunday, 08 March 2009, 15:13 GMT+2

Hi, I have tested all_changes.patch and it works great for me. I have some ideas to improve game menus in rockbox.
- same game menu for all games including playback control
- only display resume, if you can select it
- add help to all game menus, particularly to complex games like goban
I have written a patch for brickmania, which display only resume, if you can select it. It's my first patch, so please be tolerant. I'm not really satisfied with the style of my code, but I hope you can tell me, how to improve it.

Comment by Johannes Schwarz (Ubuntuxer) - Sunday, 08 March 2009, 15:14 GMT+2

Brickmania Game Menu Patch

patchfile (5.2 KiB)

Comment by Johannes Schwarz (Ubuntuxer) - Tuesday, 17 March 2009, 23:26 GMT+2

I have rework brickmania:
-add a small menu to choose difficulty
- correct buttons on Sansa

I hope it works fine for you.

brickmania_patch (20.4 KiB)

Comment by Johannes Schwarz (Ubuntuxer) - Sunday, 22 March 2009, 19:56 GMT+2

I have added a highscore list, which display the five best games.
I have to change highscore.c, but it hasn't got any effect on other plugins, which use this file. The function highscore_update() just returns the position of the input in the list.

brickmania.patch (27 KiB)

 changed_rockbox/apps/plugins/brickmania.c    |  508 +++++++++++++++------------
 changed_rockbox/apps/plugins/lib/highscore.c |    2 
 2 files changed, 294 insertions(+), 216 deletions(-)

Comment by Johannes Schwarz (Ubuntuxer) - Monday, 23 March 2009, 22:39 GMT+2

add highscore list to rockblox
improve game menu in snake

games_rework.patch (44.4 KiB)

 changed_rockbox/apps/plugins/brickmania.c    |  515 +++++++++++++++------------
 changed_rockbox/apps/plugins/lib/highscore.c |    2 
 changed_rockbox/apps/plugins/rockblox.c      |  173 +++++++--
 changed_rockbox/apps/plugins/snake.c         |  268 +++++++-------
 4 files changed, 591 insertions(+), 367 deletions(-)

	Tasks related to this task (0)

Duplicate tasks of this task (0)

Rockbox

FS#9953 - Add Playback Control to more plugins

Details

Loading...