Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#9989 - Show viewer plugins in the plugin menu.

Attached to Project: Rockbox
Opened by Yoshihisa Uchida (Uchida) - Friday, 06 March 2009, 13:37 GMT+2
Last edited by Jonathan Gordon (jdgordon) - Friday, 06 March 2009, 18:53 GMT+2
Task Type Patches
Category User Interface
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

This is a patch to display viewer category plugins in the plugin menu.
The plugin can be executed alone without selecting other files.

However, plugins other than the text viewer plugin cannot execute　alone.
   view_viewers_plugins.patch (1.9 KiB) 
 b/apps/lang/english.lang |   14 ++++++++++++++
 b/apps/root_menu.c       |    6 +++++-
 b/apps/tree.c            |    2 ++
 3 files changed, 21 insertions(+), 1 deletion(-)

This task depends upon

Closed by  Jonathan Gordon (jdgordon)
Friday, 06 March 2009, 18:53 GMT+2
Reason for closing:  Rejected
Additional comments about closing:  I agree with domonoky... also, why would you want to open the viewer plugin without choosing a file to view?
Comment by Dominik Wenger (Domonoky) - Friday, 06 March 2009, 14:36 GMT+2

Wouldnt it be better to move the text viewer to the plugin/apps directory, and correct the entry in viewers.config ? Like it is done with md5sum and the text_editor.
This way you can still use the textviewer standalone or as a viewer, but dont present all other viewer plugins to the user.

Loading...